Conversation
Member
Author
|
@metamaskbot publish-previews |
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
@metamaskbot publish-preview |
10 tasks
…not-throw-silently
Contributor
|
@metamaskbot publish-preview |
1 similar comment
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Breaking promise semantics for KYC entry points (
checkKycRequired, consents session) require consumer updates; failures still update controller state before throw, so callers must handle both rejection and state.Overview
Breaking change: several KYC controller paths still write failures to state, but now rethrow the original error instead of resolving quietly.
checkKycRequiredsetsphase: 'error'on a failed service call and then throws (it previously returnedfalse). For product-scoped MoonPay flows, that meansonAuthenticated/ frame-message handling can reject when the auto-run KYC-required check fails, not only update state.The consents-path session (
acceptTermsAndStartSession, resumedinitialize, and#startConsentsSession) still rewinds totermsand records a consents failure, then rethrows so callers can catch the underlying error. JSDoc, generated action types, tests, and the changelog document the new@throwsbehavior.Unchanged: validation-style
#fail+ return (missing token/email/country), and in-flight work superseded byreset()still avoids updating state or rethrowing.startSumSubfailures remain swallowed in#continueAfterAuthenticationso the frame handler can await safely.Reviewed by Cursor Bugbot for commit 0a8ce99. Bugbot is set up for automated code reviews on this repo. Configure here.