Skip to content

Create erc20:0x2970134F4e01a8AE77b36c37c7b688b4ADEC76CF.json - #1920

Open
armaverseio wants to merge 1 commit into
MetaMask:masterfrom
armaverseio:patch-6
Open

Create erc20:0x2970134F4e01a8AE77b36c37c7b688b4ADEC76CF.json#1920
armaverseio wants to merge 1 commit into
MetaMask:masterfrom
armaverseio:patch-6

Conversation

@armaverseio

@armaverseio armaverseio commented Aug 21, 2026

Copy link
Copy Markdown

Note

Low Risk
Static token list metadata only; no logic, auth, or data-handling changes.

Overview
Adds token metadata for ARMAVERSE (ARMA) on BNB Chain (eip155:56) at 0x2970134F4e01a8AE77b36c37c7b688b4ADEC76CF, including name, symbol, 18 decimals, and a logo path.

Reviewed by Cursor Bugbot for commit 65fadb6. Bugbot is set up for automated code reviews on this repo. Configure here.

@armaverseio
armaverseio requested review from a team and MRabenda as code owners August 21, 2026 07:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 65fadb6. Configure here.

"decimals": 18,
"erc20": true,
"logo": "./icons/eip155:56/erc20:0x2970134F4e01a8AE77b36c37c7b688b4ADEC76CF.svg"
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata file in wrong directory

High Severity

This asset metadata was added under eip155:56/ at the repo root instead of metadata/eip155:56/. buildindex.js only reads files under metadata/, so this entry is never included in contract-map.json and the token never appears in the published map.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 65fadb6. Configure here.

"symbol": "ARMA",
"decimals": 18,
"erc20": true,
"logo": "./icons/eip155:56/erc20:0x2970134F4e01a8AE77b36c37c7b688b4ADEC76CF.svg"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referenced logo file missing

High Severity

The logo field points to ./icons/eip155:56/erc20:0x2970134F4e01a8AE77b36c37c7b688b4ADEC76CF.svg, but that icon is not present in the repository. Even after moving the metadata into the correct folder, consumers would resolve a missing image path.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 65fadb6. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant