tweaks for jules-lfric metadata#625
Conversation
There was a problem hiding this comment.
I had a look at my previous PR when I imported jules-shared to the UM. /pull/138
I've identified another place which needs a tweak.
James Bruten (@james-bruten-mo) I didn't make this comment particularly clear what needed changing:
The "Important" box in https://metoffice.github.io/simulation-systems/Development/TestSuites/jules.html reads:
For jules-shared changes, when LFRic testing, the changes need to be manually synced to the LFRic location. When UM testing, this is not required as jules-shared is imported from the JULES branch.
which will need updating as it no longer needs manual syncing.
Most of the shared metadata stuff is described in the wiki which I need to migrate to GitHub. The links to this therefore are currently broken.
Co-authored-by: Maggie <145924708+maggiehendry@users.noreply.github.com>
There was a problem hiding this comment.
Please see the other comment regarding another place that needs tweaking which mentions the need to manually sync jules-shared.
Co-authored-by: Maggie <145924708+maggiehendry@users.noreply.github.com>
|
Thanks Maggie, made those further tweaks. I don't think the |
Maggie (maggiehendry)
left a comment
There was a problem hiding this comment.
Thanks for making these changes. I think it all looks good now. 😄.
Sam Clarke-Green (t00sa)
left a comment
There was a problem hiding this comment.
Changes look sensible and render correctly. PR approved and will be committed once other changes are ready to go.
PR Summary
Code Reviewer: Sam Clarke-Green (@t00sa)
This makes some minor changes surrounding shared jules metadata, linked with MetOffice/lfric_apps#463
Code Quality Checklist
Code Review