Skip to content

Add fill metadata to files and fix yamls as second observation is now rejected#278

Merged
Matt Shin (matthewrmshin) merged 2 commits intodevelopfrom
feature/bugfix_issue_277
Mar 17, 2026
Merged

Add fill metadata to files and fix yamls as second observation is now rejected#278
Matt Shin (matthewrmshin) merged 2 commits intodevelopfrom
feature/bugfix_issue_277

Conversation

@mikecooke77
Copy link
Copy Markdown
Collaborator

@mikecooke77 Michael Cooke (mikecooke77) commented Mar 16, 2026

This PR fixes #277 failing tests that have been noted in the issue.

The following changes have been made:

  1. Update the python script which produces the files to add a fill value for all the variables in the nc4 files. This script has then been run to recreate the nc4 test files.
  2. The second location for all the global varobs writer is now rejected and this is reflected in the updated yamls which have reference values.

@matthewrmshin
Copy link
Copy Markdown
Collaborator

Tested in my environment. All looking good. https://cylchub/services/cylc-review/taskjobs/matthew.shin/?suite=mobbm-oi278%2Frun1

Copy link
Copy Markdown
Collaborator

@ctgh Chris Thomas (ctgh) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comprehensive change!

@matthewrmshin Matt Shin (matthewrmshin) merged commit 39a6e91 into develop Mar 17, 2026
6 checks passed
@matthewrmshin Matt Shin (matthewrmshin) deleted the feature/bugfix_issue_277 branch March 17, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ctest failures

3 participants