-
Notifications
You must be signed in to change notification settings - Fork 11
Linter fixes to umdp3 checker #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
investigations as to whether it's worked and how it can be improved.
and is to std out whereas the origianl wrote to std err. It's not clear if the Python version terminated after the first file with errors, or genuinely didn't spot the errors in the other files. Branch used to look for errors is : https://code.metoffice.gov.uk/svn/um/main/branches/dev/roddysharp/vn13.9_deliberate_umdp3_failures
… all the edited files.
… in trunk mode...
…p3_checkas I think Perl did it for both cases..
…or a Trunk in suite..
methodology. Plus making the branch processing of files changes return a list.
…clarity and to reduce the size of umdp3.py.
hints as at every step it suggests something else...
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
…much more readable, by which I mean less readable and manky.
…ith the todo tree extension.
Contributor
Author
|
Well, that went badly - this is 'supposed' to be an update to the previous PR, but it seems to be listing ALL the files touched as new, including a bunch of files that shouldn't be tracked at aLL and is generally just a complete disaster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @Pierre-siddall
Code Reviewer:
While the previous umdp3 checker was being reviewed, I concentrated on some partial refactors mostly to reduce the number of 'problems' highlighted by the internal linter(s) in VSCode.
This branch contains those changes, but does not actually affect running the code.
I'm partially putting this into PR now to engage with @Pierre-siddall for a discussion about the OO "desighn" and perhaps to get answers to why some of these changes were required to satisfy linters when the code ran and I'm not sure what the linter is requesting is actually desired.
Especially the requirement of an init method in the 'abstract class' - although I now suspect the abstract class itself is no longer required, I'd like to know why an init method was required by the linter(s)
Code Quality Checklist
Testing
Security Considerations
AI Assistance and Attribution
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review