Updated the UI for docs Plugin#5
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the dialog components for creating, editing, and selecting diagrams, focusing on better handling of iframe navigation events and updating the plugin URL for diagram selection. The main changes are grouped below:
Iframe Navigation Handling:
Added support for handling the
'navigateBack'action with the'mermaid-chart-google-docs-back'type in the message event listeners ofCreateDiagramDialog,EditDiagramDialog, andSelectDiagramDialog. When this event is received, the dialogs will now close appropriately, improving user experience when navigating back from embedded iframes. [1] [2] [3]Updated the message event listeners in all three dialog components to extract the
typeproperty from incoming messages, enabling more precise event handling. [1] [2] [3]Plugin URL Update:
SelectDiagramDialogfrom'/app/plugins/select?pluginSource=googledocs'to'/app/plugins/confluence/select?pluginSource=googledocs', ensuring the correct plugin context is used for diagram selection.