Fix conditional beta calculations and clarify gs_cp_npe2() behavior - #664
Open
LittleBeannie wants to merge 6 commits into
Open
Fix conditional beta calculations and clarify gs_cp_npe2() behavior#664LittleBeannie wants to merge 6 commits into
gs_cp_npe2() behavior#664LittleBeannie wants to merge 6 commits into
Conversation
shiyuskaya
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects the conditional beta probability calculation in
gs_cp_npe2()and clarifies the function's behavior when the next analysis is the target analysis (j = i + 1).Related
Closes #660
Closes #661
Changes
prob_betawhenj > i + 1.binstead of the futility boundsaas the upper limits for intermediate analyses.prob_alpha,prob_alpha_plus, andprob_beta.j = i + 1andj > i + 1.gs_cp_npe2()withgs_cp_npe1()whenj = i + 1.Results
For the example reported in #661,
prob_beta[2]is corrected from0to approximately0.4437: