doctor + _common: Windows onboarding fixes and toolkit.env — DRAFT until the Windows field run is cited - #25
Draft
MendixMau wants to merge 2 commits into
Draft
doctor + _common: Windows onboarding fixes and toolkit.env — DRAFT until the Windows field run is cited#25MendixMau wants to merge 2 commits into
MendixMau wants to merge 2 commits into
Conversation
…l locations - find_sp_app: newline-join listings, dedupe identical Program Files roots, accept only version-shaped dirs (gradle-8.5 was winning sort -V glued to the next entry) - check-scripts: project without bin/ is a WARN pointing at init-project - find_project_mxcli: mxcli.exe first on Git Bash; an ELF ./mxcli (the Dev Container's) is named, not chmod-ed; --install fetches the .exe beside it; exec.sh, lint-gate, review-module, conformance-check, fixture-manifest, page-scope resolve the same way - save-sp/restart-sp section is a note off macOS, not a WARN - toolkit.env (<project>/.claude/toolkit.env, ~/.mxcli-toolkit.env) loaded by _common.sh: MENDIX_APP, JAVA_HOME, MXBUILD_PATH, MXCLI_VERSION, PYTHON; Windows paths pasted as-is; doctor reports, self-gitignores, flags a JRE without javac; gate/verdict wording guides instead of alarms Fixture-proven here; Windows field run pending. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qixv73qXUUHwVDv7fJW8Zv (cherry picked from commit 41af6f6)
… verdict wording corrected The Windows field run this instrument change needs is still owed; the PR stays draft until it is cited. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct lane — instrument change, held for field proof
What changed and why: the instrument half of PR #12 (its three docs commits landed in #22), cherry-picked with
-x.project-bin/_common.sh:mxtk_posix_path, atoolkit.envloader (<project>/.claude/toolkit.env, then~/.mxcli-toolkit.env; env vars win),mxtk_is_elf,find_project_mxcli(on Git Bash prefersmxcli.exe, refuses an ELFmxclileft by a Dev Container), and a rewrittenfind_sp_appthat no longer ranks a glued path (gradle-8.5//c/Program Files/Mendix/10.24…) highest.bin/doctor.sh: reports which toolkit.env loaded,--installfetchesmxcli.exebeside an ELFmxcli, JRE-without-javac note, macOS-only sections become notes elsewhere, self-gitignores/.claude/toolkit.env. Sixproject-bin/*scripts resolve the binary the same way.check-scripts.shwarns instead of failing on a project withoutbin/.Merge-queue review (2026-09-08): merged with four small fixes — the
.exeprobe pasted intopage-scope.shandfixture-manifest.shnow callsfind_project_mxcli(one resolver, not three copies); deadMXCLI_LINUX_SEENdropped; the_common.shcomment claiming init-project gitignores toolkit.env corrected (doctor appends it); the WARN verdict no longer calls a missing.mpr"optional". Five gates green;doctor.sh --quickruns clean on this container.Why draft — CLAUDE.md "Shipping an instrument", rules 1 and 4. The branch's own changelog says fixture-proven here; Windows field run pending, and no fixture is committed. This is a Windows-path instrument written from a non-Windows session — exactly the F-042 shape. Two things convert it to mergeable:
bin/doctor.sh --installthenbin/doctor.sh, output pasted here (redact nothing but usernames), and the CHANGELOG line updated from "still owed" to what it measured.find_sp_app: the verbatimls -dlisting that produced the glued path, committed undertests/beside a fixture asserting the expected winner.Closes #12 (superseded: docs in #22, instrument here).
_common.sh; bash-3.2 clean🤖 Generated with Claude Code
https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Generated by Claude Code