Refresh retrieval Q cache after single memory updates - #16
Draft
Frankie-Xu wants to merge 1 commit into
Draft
Frankie-Xu wants to merge 1 commit into
Frankie-Xu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryService.update_value persists a new Q value but leaves an already populated retrieval Q cache unchanged. A retrieve → single update → retrieve sequence can therefore keep ranking memories with the old Q value.
After a successful non-None updater result, refresh the cache using the same FIFO capacity policy as update_values. Disabled/null actions, None results, and persistence failures leave the cache unchanged. The Q-learning formula and retrieval policy are unchanged.
Validation:
No live MemOS integration, LLM benchmark, or Python version matrix was run. This change is independent of the finite-value validation in PR #14.