Repository navigation
fix: verify selected zip member checksums - #291
Merged
Merged
Conversation
Mearman
marked this pull request as ready for review
November 6, 2026 07:56
Mearman
enabled auto-merge (rebase)
November 6, 2026 07:56
|
🎉 This PR is included in version 0.125.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZIP member reads previously trusted the central directory's length and returned decoded bytes without checking the member's CRC-32. Corrupted stored data, or deflated data that still decodes, could therefore reach a dataset parser unnoticed.
Check the decoded length and CRC-32 against the central directory for both whole and streamed reads, including ZIP64. Tests cover corrupted stored data, a mismatched deflated checksum and incorrect lengths. Build, typecheck, lint, seed checks and 1,367 tests passed.