Make name a non-optional str with a sensible default#96
Draft
Make name a non-optional str with a sensible default#96
name a non-optional str with a sensible default#96Conversation
Copilot
AI
changed the title
[WIP] Add name attribute to ButterBackup configurations
Add Mar 25, 2026
name attribute to backup configurations, defaulting to UUID
Copilot stopped work on behalf of
MaxG87 due to an error
March 25, 2026 14:17
Copilot
AI
changed the title
Add
Make Mar 25, 2026
name attribute to backup configurations, defaulting to UUIDname a required str field in BaseConfig
Copilot
AI
changed the title
Make
Make Mar 25, 2026
name a required str field in BaseConfigname a non-optional str with a sensible default
Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com> Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/930a0746-0737-404f-b371-babf323a7e8b
MaxG87
force-pushed
the
copilot/add-name-attribute-to-butterbackup-configs
branch
from
12fb57b to
ee04fb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: strwith no default caused mypy to treat it as a required constructor argument, breaking the 4 call sites that omit it and rely on themodel_validatorto populate it fromUUID.Changes
config_parser.py: Setname: str = ""— keeps thestrtype, adds an empty-string default so mypy is satisfied. The existingmodel_validator(mode="before")already replaces falsy values (including"") with the UUID string, so runtime behaviour is unchanged.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.