Conversation
e4ec324 to
a46acb4
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses a critical data-loss scenario by pinning/updating the storage-device-managers dependency to a fixed version and adding a regression test to ensure unmount failures do not delete backup contents.
Changes:
- Add a regression test that simulates an unmount failure and verifies backups are not deleted and the device can still be closed.
- Bump runtime/dev dependencies (notably
storage-device-managers,shell-interface,typer) and updateuv.lockaccordingly. - Update Docker/CI tooling to use a newer
uvversion and add YAML document headers to workflows/config.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Updates locked dependency set to match bumped runtime/dev requirements (incl. storage-device-managers>=1.0.1, pytest-mock). |
pyproject.toml |
Bumps runtime/dev dependency minimums and adds pytest-mock for the new regression test. |
tests/test_cli.py |
Adds regression test covering the unmount-error/backup-deletion scenario. |
tests/conftest.py |
Tightens fixture typing annotations (and imports typing as t). |
dockerfiles/python3.10 |
Updates pinned uv version used in Docker test environment. |
dockerfiles/python3.11 |
Updates pinned uv version used in Docker test environment. |
dockerfiles/python3.12 |
Updates pinned uv version used in Docker test environment. |
dockerfiles/python3.13 |
Updates pinned uv version used in Docker test environment. |
dockerfiles/python3.14 |
Updates pinned uv version used in Docker test environment. |
.github/workflows/python-ci.yml |
Pins CI install of uv to 0.10.12 and adds YAML document marker. |
.github/workflows/python-publish.yml |
Adds YAML document marker (but still pins an older uv, see comment). |
.github/workflows/release-please.yml |
Adds YAML document marker. |
.github/dependabot.yml |
Adds YAML document marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a bug in an imported component, storage_device_managers,
errors during the unmount would result in deletion of the entire
backup. This is a serious issue for a backup tool!
This branch first establishes a test that covers the wrong
behaviour. Then the erroneous component is updated, which fixes the bug.