Skip to content

fix(events): accept numeric reaction message ids #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShiroKSH wants to merge 1 commit into
base: dev/2.5.0
Choose a base branch
from
Open

fix(events): accept numeric reaction message ids #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pymax/types/events/reaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class ReactionUpdateEvent(CamelModel):
"""Событие обновления реакций сообщения.
:ivar message_id: ID сообщения.
:vartype message_id: str
:vartype message_id: int
:ivar chat_id: ID чата.
:vartype chat_id: int
:ivar counters: Счетчики реакций по типам.
Expand All @@ -15,7 +15,7 @@ class ReactionUpdateEvent(CamelModel):
:vartype total_count: int
"""

message_id: str
message_id: int
chat_id: int
counters: list[ReactionCounter] | None = None
total_count: int = 0
6 changes: 3 additions & 3 deletions tests/dispatch/test_dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ async def test_dispatcher_maps_reaction_update_event() -> None:
router: Router[str] = Router()
dispatcher: Dispatcher[str] = Dispatcher(app, router)
dispatcher.bind_client("client")
seen: list[tuple[str, int, int, int, str]] = []
seen: list[tuple[int, int, int, int, str]] = []

@router.on_reaction_update()
async def on_reaction_update(event, _client):
Expand All @@ -234,7 +234,7 @@ async def on_reaction_update(event, _client):
await dispatcher.dispatch(
frame(
{
"messageId": "116739131144745294",
"messageId": 116739131144745294,
"chatId": 239067070,
"counters": [{"count": 1, "reaction": "👍"}],
"totalCount": 1,
Expand All @@ -244,7 +244,7 @@ async def on_reaction_update(event, _client):
)
)

assert seen == [("116739131144745294", 239067070, 1, 1, "👍")]
assert seen == [(116739131144745294, 239067070, 1, 1, "👍")]


@pytest.mark.asyncio
Expand Down
Loading