Skip to content

Stop the process before terminating it #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nevse wants to merge 1 commit into from
Closed

Stop the process before terminating it #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/SharpDbg.Infrastructure/Debugger/ManagedDebugger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,10 @@ private void Dispose()

// Unsubscribe from callbacks to avoid any further event dispatch
_callbacks.OnAnyEvent -= QueueEvent;
_runtimeEventChannel.Writer.Complete();
// TryComplete because this can run twice: Terminate disposes whether or not it succeeded, so a
// client that sends terminate and then disconnect would get a ChannelClosedException out of the
// second one
_runtimeEventChannel.Writer.TryComplete();
// ProcessRuntimeEventQueue is blocked on DapRequestAndRuntimeEventLock (which we hold) and would
// never complete if we waited on it here — that is the deadlock. Read and discard remaining events ourselves,
// then let the processor exit once the lock is released.
Expand Down
9 changes: 9 additions & 0 deletions src/SharpDbg.Infrastructure/Debugger/ManagedDebugger_RequestHandlers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,15 @@ public void Terminate()
{
try
{
// Terminate needs the process synchronized. On a running one it fails with
// CORDBG_E_PROCESS_NOT_SYNCHRONIZED and leaves the debuggee running.
if (_process.TryIsRunning(out var isRunning) is Cor.S_OK && isRunning)
{
var stopHResult = _process.TryStop(0);
if (stopHResult is not (Cor.S_OK or Cor.CORDBG_E_PROCESS_TERMINATED))
_logger?.Invoke($"Error stopping process before terminating it: {stopHResult}");
}

_process.Terminate(0);
}
catch (Exception ex)
Expand Down