-
Notifications
You must be signed in to change notification settings - Fork 11
fix: Add all the stuff #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xpuska513
wants to merge
1
commit into
master
Choose a base branch
from
kskobylko-hiring-challenge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| DB_HOST=localhost | ||
| DB_PORT=5432 | ||
| DB_NAME=inventory | ||
| DB_USER=postgres | ||
| DB_PASSWORD=postgres | ||
|
|
||
| DEBUG=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| venv/ | ||
| env/ | ||
| .venv/ | ||
| .env/ | ||
| __pycache__/ | ||
|
|
||
| .pytest_cache/ | ||
|
|
||
|
|
||
| postgres_data/ | ||
|
|
||
| # Local dev stuff | ||
| .env | ||
| .env.local | ||
|
|
||
| # MacOS BS | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| server_inventory.egg-info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| FROM python:3.11-slim | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY requirements.txt . | ||
| RUN pip install --no-cache-dir -r requirements.txt | ||
|
|
||
| COPY api/ ./api/ | ||
| COPY cli/ ./cli/ | ||
|
|
||
| EXPOSE 8000 | ||
|
|
||
| CMD ["uvicorn", "api.main:app", "--host", "0.0.0.0", "--port", "8000"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,61 @@ | ||||||||||||||||||||||||||||||||||
| .PHONY: install dev test clean docker-up docker-down | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| PYTHON := $(shell command -v .venv/bin/python 2>/dev/null || echo python3) | ||||||||||||||||||||||||||||||||||
| PIP := $(shell command -v .venv/bin/pip 2>/dev/null || echo pip3) | ||||||||||||||||||||||||||||||||||
| PYTEST := $(shell command -v .venv/bin/pytest 2>/dev/null || echo pytest) | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| help: | ||||||||||||||||||||||||||||||||||
| @echo "make install - install deps" | ||||||||||||||||||||||||||||||||||
| @echo "make dev - run dev server" | ||||||||||||||||||||||||||||||||||
| @echo "make test - run tests" | ||||||||||||||||||||||||||||||||||
| @echo "make run - start stack" | ||||||||||||||||||||||||||||||||||
| @echo "make stop - stop stack" | ||||||||||||||||||||||||||||||||||
| @echo "make clean - cleanup" | ||||||||||||||||||||||||||||||||||
| @echo "make install-cli- install CLI tool" | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| install: | ||||||||||||||||||||||||||||||||||
| $(PIP) install -r requirements.txt | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| install-dev: install | ||||||||||||||||||||||||||||||||||
| $(PIP) install -r requirements-dev.txt | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| dev: | ||||||||||||||||||||||||||||||||||
| $(PYTHON) -m uvicorn api.main:app --reload | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| install-cli: install | ||||||||||||||||||||||||||||||||||
| $(PIP) install -e . | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| test: | ||||||||||||||||||||||||||||||||||
| DB_HOST=localhost DB_PORT=5433 DB_NAME=inventory_test DB_USER=postgres DB_PASSWORD=postgres \ | ||||||||||||||||||||||||||||||||||
| $(PYTEST) -v | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| test-cov: | ||||||||||||||||||||||||||||||||||
| DB_HOST=localhost DB_PORT=5433 DB_NAME=inventory_test DB_USER=postgres DB_PASSWORD=postgres \ | ||||||||||||||||||||||||||||||||||
| $(PYTEST) --cov=api --cov-report=html | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+29
to
+34
|
||||||||||||||||||||||||||||||||||
| DB_HOST=localhost DB_PORT=5433 DB_NAME=inventory_test DB_USER=postgres DB_PASSWORD=postgres \ | |
| $(PYTEST) -v | |
| test-cov: | |
| DB_HOST=localhost DB_PORT=5433 DB_NAME=inventory_test DB_USER=postgres DB_PASSWORD=postgres \ | |
| $(PYTEST) --cov=api --cov-report=html | |
| set -a; \ | |
| [ -f .env.test ] && . .env.test; \ | |
| set +a; \ | |
| $(PYTEST) -v | |
| test-cov: | |
| set -a; \ | |
| [ -f .env.test ] && . .env.test; \ | |
| set +a; \ | |
| $(PYTEST) --cov=api --cov-report=html |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The help text formatting is inconsistent. "make install-cli- install CLI tool" is missing a space between "install-cli" and the dash. It should be "make install-cli - install CLI tool".