fix: resolve this-binding bug blocking vitest 4 upgrade#318
Open
russongit wants to merge 1 commit into
Open
Conversation
Replace this.getTA/this.getUser calls with module.exports references in searchMarket, searchMarketV3, and getUser's redirect recursion, matching the pattern already used elsewhere in miscRequests.js. This was breaking under vitest 4's ESM/CJS interop when functions were called via destructured imports rather than as object methods. Also bumps vitest to 4.1.9 (via npm audit fix --force), resolving the remaining esbuild/vite/vitest vulnerability chain (0 vulnerabilities now).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm auditvulnerabilities in the esbuild/vite/vitest dependency chain by upgrading vitest to 4.1.9this-binding bug insrc/miscRequests.js:searchMarket,searchMarketV3, andgetUser's redirect recursion calledthis.getTA(...)/this.getUser(...), which only worked when these functions were invoked as object methods. Under vitest 4's ESM/CJS interop, tests import these via destructured named imports, sothisno longer resolved correctly.this.X(...)calls withmodule.exports.X(...), matching the pattern already used elsewhere in the same file (getIndicator,getChartTokencalls).Test plan
npm auditreports 0 vulnerabilities after the upgrade