console: render environment-not-ready flow in the standard layout

[jubrad]

Motivation

The environment-not-ready flow used a stripped custom layout with no navigation, so users without an enabled environment could not see or reach account-scoped pages like App Passwords, License, or Usage & Billing. A blocked or trial-expired organization, by contrast, already renders the full BaseLayout with those links visible, so the two states were inconsistent.

Changes

• Render EnvironmentNotReadyRoutes inside BaseLayout, so users without an enabled environment get the standard chrome (error boundary, suspense fallback, footer) and can reach account-scoped pages.

• The nav in this flow is account-only via a new accountOnly nav mode: only the Admin group renders, and the Create New button is hidden. Gating on the route rather than environment health means a transient health reading can never flash the full sidebar mid-boot. The full sidebar appears once the user continues to a working console.

• The waiting page (the "We're creating your environment" slides with the "Open console" button) is restyled to center in the layout's content area like the enable-region page, replacing the absolute viewport positioning from the old standalone layout.

• Suppress the welcome dialog in this flow via a new BaseLayout prop. It pops the moment a region becomes healthy and its modal covered the tutorial's "Open console" button (caught by the e2e suite).

• Preserve the region-ready toast in a headless RegionReadyToast component. Its unmount cleanup reads the unstable toast reference through a ref rather than an eslint-disable, which the react-compiler lint rule no longer accepts.

• Delete the custom Layout.tsx (EnvironmentNotReadyLayout, EnvironmentNotReadyStatus).

• The logo already links back to the enable-region flow while no environment is ready (/ redirects there), so no extra nav entry was added.

• Fix the environment health probe treating SQL-level errors as an immediate crashed even during the boot window. A freshly provisioned environmentd can respond with errors before it is fully initialized, and since isEnvironmentReady counts crashed as ready, one transient error routed users into a console that could not serve queries yet. SQL errors now get the same maxBootDuration grace as connection failures.

• Harden the onboarding slide clicks in the e2e suite: a click can be swallowed when the environment flips to healthy mid-transition (the slide content suspends for a frame and the anchor detaches), leaving the page on the same slide. Each click now verifies the next slide's heading appeared and retries when it didn't.

Tests

• Adds a test asserting the Admin nav group (App Passwords, Usage & Billing) renders on the enable-region page with no enabled environment, and that region-scoped items stay hidden.
• Adds a test asserting the welcome dialog stays suppressed on the tutorial page once a region is healthy.
• Adds health probe tests: SQL error within the boot window reports booting, after the window reports crashed. The test provider wrapper now nests ToastProvider inside the router to match the app, so toasts can render router Links.

Checklist

• This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
• This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
• If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
• If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
• If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

🤖 Generated with Claude Code

[def-]

I don't think this test actually does anything. Probably have to wait a bit more

Suggested change

	expect(
	screen.queryByTestId("welcome-dialog-close-button"),
	).not.toBeInTheDocument();
	await expect(
	screen.queryByTestId("welcome-dialog-close-button"),
	).rejects.toThrow();

[jubrad]

Good catch, this test was asserting nothing. Confirmed by mutation testing: with hideWelcomeDialog removed from BaseLayout, the test still passed.

The cause is that the dialog mounts asynchronously (WelcomeDialogContent flips showModal in an effect, and Chakra portals it in), so the synchronous queryByTestId ran before it ever had a chance to appear.

Your instinct to use .rejects.toThrow() was right, it just needs findByTestId rather than queryByTestId since the latter returns an element-or-null rather than a promise. Also passing an explicit 2s timeout, because the suite-wide asyncUtilTimeout is 10s and this negative assertion would otherwise burn the whole budget (the test went from 10.1s to 2.1s).

Now verified in both directions: fails without hideWelcomeDialog, passes with it. I mutation tested the two nav assertions in this file the same way and they do fail correctly when accountOnlyNav is removed.

[jubrad]

thanks!

[def-]

No further complaints from QA side