adapter: Add a binary encoding for int2vector#35439
adapter: Add a binary encoding for int2vector#35439mgree merged 3 commits intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
ggevay
left a comment
There was a problem hiding this comment.
LGTM
(Tons of Nightly failures, but I guess unrelated.)
|
bugbot run |
PR SummaryMedium Risk Overview Updates testdrive result decoding to treat Written by Cursor Bugbot for commit 44c4e6d. This will update automatically on new commits. Configure here. |
### Motivation When writing #35324, I ran into an issue where testdrive crashed because my query was returning an int2vector. ### Description Postgres serializes an int2vector like a 1-dimensional array with a 0 lower bound. NB that int2vector _should_ be non-nullable, but I copied the array nullability logic rather than asserting as much. ### Verification New test in `int2vector_binary.td`.
### Motivation When writing #35324, I ran into an issue where testdrive crashed because my query was returning an int2vector. ### Description Postgres serializes an int2vector like a 1-dimensional array with a 0 lower bound. NB that int2vector _should_ be non-nullable, but I copied the array nullability logic rather than asserting as much. ### Verification New test in `int2vector_binary.td`.
Motivation
When writing #35324, I ran into an issue where testdrive crashed because my query was returning an int2vector.
Description
Postgres serializes an int2vector like a 1-dimensional array with a 0 lower bound.
NB that int2vector should be non-nullable, but I copied the array nullability logic rather than asserting as much.
Verification
New test in
int2vector_binary.td.