kafka sink: Fix: Correctly write out negative timestamps with Avro#35426
Merged
def- merged 1 commit intoMaterializeInc:mainfrom Mar 13, 2026
Merged
kafka sink: Fix: Correctly write out negative timestamps with Avro#35426def- merged 1 commit intoMaterializeInc:mainfrom
def- merged 1 commit intoMaterializeInc:mainfrom
Conversation
Another one-liner fix, the rest is adding a test. This has been broken since the very beginning: MaterializeInc#2181
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
antiguru
pushed a commit
to antiguru/materialize
that referenced
this pull request
Mar 26, 2026
…aterializeInc#35426) Another one-liner fix, the rest is adding a test. This has been broken since the very beginning: MaterializeInc#2181, but probably only became relevant with Kafka sinks being introduced. > timestamp-micros: logical type annotates an Avro long, where the long stores the number of microseconds from the unix epoch, 1 January 1970 00:00:00.000000. From https://avro.apache.org/docs/1.12.0/specification/#logical-types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another one-liner fix, the rest is adding a test.
This has been broken since the very beginning: #2181, but probably only became relevant with Kafka sinks being introduced.
From https://avro.apache.org/docs/1.12.0/specification/#logical-types