sql: Fix autorouting for expensive functions#35413
Merged
def- merged 2 commits intoMaterializeInc:mainfrom Mar 16, 2026
Merged
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
antiguru
approved these changes
Mar 11, 2026
ggevay
approved these changes
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Yes, thank you, this is definitely fixing a bug!
(I hope fixing this won't break somebody's dbt workflows. The PR will make some queries not run on mz_catalog_server, but on the active cluster, and 6a93648's commit msg says that the auto-routing of simple queries was introduced to "help some dbt use cases". I hope those dbt queries will still be covered. Unfortunately that commit doesn't seem to have added tests for the specific dbt queries. Tbh, this whole auto-routing feels quite messy.)
Only top-level expensive functions were considered in the auto-routing Broken in MaterializeInc#20994 One line fix, the rest is adding tests that actually made me find this.
7c63dfb to
0af11ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only top-level expensive functions were considered in the auto-routing
Broken in #20994
One line fix, the rest is adding tests that actually made me find this. Without the production code change the tests fail like this: