adapter: Fix: Don't ignore RETAIN HISTORY value for webhooks#35408
Merged
def- merged 1 commit intoMaterializeInc:mainfrom Mar 12, 2026
Merged
adapter: Fix: Don't ignore RETAIN HISTORY value for webhooks#35408def- merged 1 commit intoMaterializeInc:mainfrom
def- merged 1 commit intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
7e5cdb4 to
794571b
Compare
Broken since MaterializeInc#31001 Also changed test/retain-history to allow running the workflows there individually
794571b to
3e213f4
Compare
mtabebe
approved these changes
Mar 12, 2026
Contributor
mtabebe
left a comment
There was a problem hiding this comment.
The change looks reasonable to me.
Out of curiosity, do we have any tests for the retain history given the real time component of it?
antiguru
approved these changes
Mar 12, 2026
Contributor
Author
|
Yes, test/retain-history, but it's been too flaky to enable, see the linked issue: https://github.com/MaterializeInc/database-issues/issues/7310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken by #31001. This is mostly adding a test, the fix is a one-liner, and then some code to have
unreachablein case we add a new kind of table and forget this again.Reproducer:
bin/mzcompose --find retain-history down && bin/mzcompose --find retain-history run webhook-table