Skip to content

adapter: Fix: Don't ignore RETAIN HISTORY value for webhooks#35408

Merged
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-webhook-retain-history
Mar 12, 2026
Merged

adapter: Fix: Don't ignore RETAIN HISTORY value for webhooks#35408
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-webhook-retain-history

Conversation

@def-
Copy link
Contributor

@def- def- commented Mar 10, 2026

Broken by #31001. This is mostly adding a test, the fix is a one-liner, and then some code to have unreachable in case we add a new kind of table and forget this again.

Reproducer: bin/mzcompose --find retain-history down && bin/mzcompose --find retain-history run webhook-table

@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def- def- force-pushed the pr-webhook-retain-history branch 2 times, most recently from 7e5cdb4 to 794571b Compare March 10, 2026 22:07
Broken since MaterializeInc#31001

Also changed test/retain-history to allow running the workflows there individually
@def- def- force-pushed the pr-webhook-retain-history branch from 794571b to 3e213f4 Compare March 10, 2026 22:14
@def- def- marked this pull request as ready for review March 10, 2026 22:24
@def- def- requested a review from a team as a code owner March 10, 2026 22:24
@def- def- requested a review from mtabebe March 10, 2026 22:24
Copy link
Contributor

@mtabebe mtabebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks reasonable to me.

Out of curiosity, do we have any tests for the retain history given the real time component of it?

@def-
Copy link
Contributor Author

def- commented Mar 12, 2026

Yes, test/retain-history, but it's been too flaky to enable, see the linked issue: https://github.com/MaterializeInc/database-issues/issues/7310

@def- def- merged commit 28fcb17 into MaterializeInc:main Mar 12, 2026
127 checks passed
@def- def- deleted the pr-webhook-retain-history branch March 12, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants