Skip to content

fix(combobox): allow dropdown toggle when clicking prefix or suffix text #4091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 1 commit into from
Sep 11, 2026
+37 −0
Merged

fix(combobox): allow dropdown toggle when clicking prefix or suffix text #4091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.ComboBox.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@
Grid.Column="1"
Margin="0,0,2,0"
FontSize="{TemplateBinding FontSize}"
IsHitTestVisible="False"
Opacity="{TemplateBinding wpf:HintAssist.HintOpacity}"
Text="{TemplateBinding wpf:TextFieldAssist.PrefixText}"
VerticalAlignment="Center">
Expand Down Expand Up @@ -446,6 +447,7 @@
Grid.Column="3"
Margin="2,0,0,0"
FontSize="{TemplateBinding FontSize}"
IsHitTestVisible="False"
Opacity="{TemplateBinding wpf:HintAssist.HintOpacity}"
Text="{TemplateBinding wpf:TextFieldAssist.SuffixText}"
VerticalAlignment="Center">
Expand Down
35 changes: 35 additions & 0 deletions tests/MaterialDesignThemes.UITests/WPF/ComboBoxes/ComboBoxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,4 +299,39 @@ public async Task ComboBox_UsesDropDownBackgroundResource_WhenBackgroundIsNotSet
await Assert.That(popupBackground).IsNotNull();
await Assert.That(popupBackground).IsEqualTo((Color)ColorConverter.ConvertFromString("#CC336699"));
}

[Test]
[Description("https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/issues/4090")]
public async Task ComboBox_OpensDropDown_WhenClickingOnPrefixOrSuffixTextBlock()
{
var comboBox = await LoadXaml<ComboBox>($"""
<ComboBox materialDesign:TextFieldAssist.PrefixText="Some prefix"
materialDesign:TextFieldAssist.SuffixText="Some suffix"
SelectedIndex="1">
<ComboBoxItem Content="Android" />
<ComboBoxItem Content="iOS" />
<ComboBoxItem Content="Linux" />
<ComboBoxItem Content="Windows" />
</ComboBox>
""");

await Assert.That(await comboBox.GetIsDropDownOpen()).IsFalse();

var prefixTextBlock = await comboBox.GetElement<TextBlock>("PrefixTextBlock");
await AssertOpensAndClosesDropDown(prefixTextBlock);

var suffixTextBlock = await comboBox.GetElement<TextBlock>("SuffixTextBlock");
await AssertOpensAndClosesDropDown(suffixTextBlock);

async Task AssertOpensAndClosesDropDown(IVisualElement<TextBlock> textBlock)
{
await textBlock.LeftClick();
await Task.Delay(50, TestContext.Current!.Execution.CancellationToken);
await Assert.That(await comboBox.GetIsDropDownOpen()).IsTrue();

await textBlock.LeftClick();
await Task.Delay(50, TestContext.Current!.Execution.CancellationToken);
await Assert.That(await comboBox.GetIsDropDownOpen()).IsFalse();
}
}
}
Loading