Repository navigation
feat(web): GitHub-style Changes view for compare mode - #11
Merged
Merged
Conversation
A "Changes" tab next to the compare overview (#/diff/files) lists every changed component the way a pull request lists changed files: a tree of the components by schema file (status, breaking dot, scroll-spy), and a card per component with its semantic changes, notes under the source lines they are about, and the source diff (split or unified, word highlights, @@ hunks with real line numbers, folded unchanged lines). Cards load as they scroll near, can be marked viewed (stored per pair of versions), and filters, layout and the current card are kept in the link. Keys: j/k, v, s, t, /. The source loading and the diff table move out of the side-by-side panel into views/codeDiff.ts, shared by both; it now also shows JSON Schema sources and colours the XML in the diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mathias · project thread
Summary
This adds a Changes tab next to the compare overview (
#/diff/files). It shows every changed component the way a pull request shows changed files. It follows the mockup approved in the project thread.@@hunks with real line numbers, and "Show N unchanged lines" to unfold hidden lines. Docs-only components and long added or removed ones wait behind "Load diff". Cards render only when they scroll near.The source loading and diff table move out of
sbsSourcePanelintoviews/codeDiff.ts, which both views now share. Side by side gains three things from that: JSON Schema sources, XML colouring, and removed lines listed above added ones in unified mode.Testing
npm run check, the app build and the lib typecheck pass.Generated by Claude Code