Repository navigation
fix(sync): stop resending tombstones that predate a full sync - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first incremental sync after a full sync resent every tombstone newer than the stream's newest upserted row. On prod that was 1,304
TimetableDeleteV1lines, none for a row the client had received.A full sync gives the client no delete ack, so the next sync used the upsert ack as the delete floor. Timetable prunes (
DeleteTimetablesBefore) andsyncAlldeletes write tombstones after the last upsert, so they all landed above that floor. Every stream does this; timetables just prune the most.Fix
When a client has no upsert ack for a stream, send only the newest tombstone before
nowId, ahead of the upserts. Its ack becomes the client's delete floor.The other option was to use the
SyncCompleteV1ack as the delete floor. I didn't, because it skips tombstones from writes still in flight during the sync, and from streams the client left out of its last request.Tests