Repository navigation
feat(sync): add RoutesV2 with isLoop and order gameday directions pregame first - #13
Merged
Merged
Conversation
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
sequence0 and Postgamesequence1. Other routes keep the upstream order. Right now 6 of the 12 Gameday routes list Postgame first.route.isLoopcolumn. It isfalsewhenlongNamestarts with "Gameday". The migration starts existing rows attrue, and the next route data sync marks the Gameday routes.RoutesV2→RouteV2(addsisLoop) +RouteDeleteV2.RoutesV1is unchanged.openapi.jsonis regenerated.Notes
isLoophas no bundefaulttag. With one, bun insertsDEFAULTfor afalsevalue, and Gameday routes would be stored astrue. A medium test inroute_data_repository_test.gocovers this.RoutesV2has its own delete type because theSyncStreamsunit test requires it. I added a row todocs/design/sync-stream.md.Old app compatibility
RoutesV1lines still leave outisLoop. A controller test covers this.RoutesV1andRoutesV2together returns 400.sequencere-sends thoseDirectionV1rows.Deploy
Deploy this before the matching app release. The app requests
RoutesV2.