Repository navigation
fix(sync): parse RoutesV2 lines - #230
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
#229 switched the sync request to
RoutesV2and added handlers forRouteV2/RouteDeleteV2, but the zod schema insync-lines.tsonly knowsRouteV1. Every sync onmainfails withunreadable sync line ... No matching discriminator.RouteV2(withisLoop) andRouteDeleteV2tosyncStreamLineSchemaSyncEntityTypein the OpenAPI spec, sopnpm checkfails the next time a line type is added without a schema entry (verified it fails without this fix)Issue number and link
Regression from #229
Dependency Changes
None
Checklist before requesting a review