Skip to content

fix(sync): parse RoutesV2 lines - #230

Merged
bwees merged 1 commit into
mainfrom
fix/sync-route-v2-schema
Nov 14, 2026
Merged

bwees merged 1 commit into
mainfrom
fix/sync-route-v2-schema

Conversation

@bwees

@bwees bwees commented Nov 14, 2026

Copy link
Copy Markdown
Member

Describe your changes

#229 switched the sync request to RoutesV2 and added handlers for RouteV2/RouteDeleteV2, but the zod schema in sync-lines.ts only knows RouteV1. Every sync on main fails with unreadable sync line ... No matching discriminator.

  • Adds RouteV2 (with isLoop) and RouteDeleteV2 to syncStreamLineSchema
  • Adds a type-level test that the schema covers every SyncEntityType in the OpenAPI spec, so pnpm check fails the next time a line type is added without a schema entry (verified it fails without this fix)

Issue number and link

Regression from #229

Dependency Changes

None

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have verified that any UI changes I have made work in dark mode
  • All of my GitHub checks have passed
  • I have added any new packages/updates above
  • I have verified that I am not submitting other changes/features outside the scope of my PR

@bwees
bwees merged commit 63e6e89 into main Nov 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant