feat(plotnine): implement waffle-basic#9953
Open
github-actions[bot] wants to merge 2 commits into
Open
Conversation
Regen from quality 79. Addressed:
- data values now sum to exactly 100 (39/28/20/13) instead of 90,
closing the ~10% proportional gap (SC-02/DQ-03)
- canvas corrected to canonical square 2400x2400 (figure_size=(6,6),
dpi=400) — previous figsize=(16,9)/dpi=300 was historical drift,
not on the Step 0 contract
- added subtitle with a realistic $5,000 monthly-budget scenario and
per-category dollar amounts in the legend for data storytelling
(DE-03)
- added an explanatory caption ("each square = 1% of budget") using
plotnine's labs(caption=...) for reader guidance
- switched to theme_void() base + bold/italic typographic hierarchy
(title/subtitle/caption) for more intentional typography (DE-01/02)
- blanked legend key background so swatches sit flush on the page
surface instead of a default grey box
- kept the perfect theme adaptation, Imprint palette order, and
contiguous reading-order block layout from the previous version
Contributor
Author
🔧 AI Review Produced No Score — Auto-RetryingThe Claude Code Action ran but didn't write |
Contributor
Author
❌ AI Review Failed (auto-retry exhausted)The AI review action completed but did not produce valid output files. Auto-retry already tried once. What happened:
Manual rerun: |
github-actions
Bot
added
ai-review-failed
Contributor
Author
❌ AI Review Failed (auto-retry exhausted)The AI review action completed but did not produce valid output files. Auto-retry already tried once. What happened:
Manual rerun: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation:
waffle-basic- python/plotnineImplements the python/plotnine version of
waffle-basic.File:
plots/waffle-basic/implementations/python/plotnine.pyParent Issue: #998
🤖 impl-generate workflow