feat(altair): implement waffle-basic#9952
Open
github-actions[bot] wants to merge 2 commits into
Open
Conversation
Regen from quality 83. Addressed:
- Title format (SC-04 failed → fixed): now uses the mandated
`{spec-id} · {language} · {library} · anyplot.ai` format with the
required language token, plus a data-driven subtitle for storytelling.
- Design Excellence (DE-01/DE-03): added a subtitle calling out the
largest allocation, and squared up the canvas (10x10 grid reads
naturally as a symmetric square format rather than landscape).
- Library Mastery (LM-02 failed → fixed): added a legend-bound
`selection_point` that dims non-selected categories on click in the
interactive HTML export — idiomatic altair, doesn't touch the default
static PNG state.
- Canvas contract: switched to square orientation (2400x2400) with the
canonical altair inner-view sizing (430x430 @ scale_factor=4.0) plus
the mandatory pad-to-target block; previous figsize (1600x900 @
scale_factor=3.0) was historical drift, off-target for the current
hard-contract sizes.
- Kept: 10x10 grid structure, budget-allocation data scenario, Imprint
categorical order, theme-adaptive chrome, legend-with-percentages.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
🔧 AI Review Produced No Score — Auto-RetryingThe Claude Code Action ran but didn't write |
github-actions
Bot
added
the
ai-review-failed
Contributor
Author
❌ AI Review Failed (auto-retry exhausted)The AI review action completed but did not produce valid output files. Auto-retry already tried once. What happened:
Manual rerun: |
github-actions
Bot
added
ai-review-rescued
Contributor
Author
❌ AI Review Failed (auto-retry exhausted)The AI review action completed but did not produce valid output files. Auto-retry already tried once. What happened:
Manual rerun: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation:
waffle-basic- python/altairImplements the python/altair version of
waffle-basic.File:
plots/waffle-basic/implementations/python/altair.pyParent Issue: #998
🤖 impl-generate workflow