feat(bokeh): implement waffle-basic#9951
Open
github-actions[bot] wants to merge 2 commits into
Open
Conversation
Regen from quality 88. Addressed:
- canvas drifted to 4800x2700 (illegal size) → fixed to canonical 3200x1800,
scaled all sizing/margins/legend proportionally, added the CDP
setDeviceMetricsOverride step so the screenshot lands exactly on target
- title missing the mandated {language} token → now
"... · waffle-basic · python · bokeh · anyplot.ai", fontsize scaled to
the exact rendered length (SC-04)
- stale "Okabe-Ito palette" comment → corrected to "Imprint palette"
- design excellence (DE-01/DE-03): added a framing card behind the grid for
composition, fill_alpha emphasis on the leading category as a focal point,
and a legend title for context
- library mastery (LM-02): legend.click_policy="hide" for real interactive
category toggling (bokeh-idiomatic, not fake)
- legend/glyph sizes rescaled to the sizing-table targets for the new canvas
(34pt label text, up from an under-scaled 18pt)
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
🔧 AI Review Produced No Score — Auto-RetryingThe Claude Code Action ran but didn't write |
github-actions
Bot
added
the
ai-review-failed
Contributor
Author
❌ AI Review Failed (auto-retry exhausted)The AI review action completed but did not produce valid output files. Auto-retry already tried once. What happened:
Manual rerun: |
github-actions
Bot
added
ai-review-rescued
Contributor
Author
❌ AI Review Failed (auto-retry exhausted)The AI review action completed but did not produce valid output files. Auto-retry already tried once. What happened:
Manual rerun: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation:
waffle-basic- python/bokehImplements the python/bokeh version of
waffle-basic.File:
plots/waffle-basic/implementations/python/bokeh.pyParent Issue: #998
🤖 impl-generate workflow