feat(makie): implement area-elevation-profile

[github-actions]

Implementation: area-elevation-profile - julia/makie

Implements the julia/makie version of area-elevation-profile.

File: plots/area-elevation-profile/implementations/julia/makie.jl

Parent Issue: #4578

---

🤖 impl-generate workflow

[claude]

AI Review - Attempt 1/3

Image Description

Light render (plot-light.png): Warm off-white (#FAF8F1) background. The terrain profile is rendered as a filled silhouette in Imprint brand green (#009E73) at 28% alpha, with a solid green profile line (linewidth 2.5) on top. Six landmarks are annotated: Trailhead (0 km, 983 m) at bottom-left, First Pass (18 km, 2753 m), Summit Peak (35 km, 3221 m) near the top center, Col de Neige (45 km, 2597 m) with label offset downward, Grand Col (60 km, 2888 m), and Trail End (80 km, 1039 m) at bottom-right. Connector lines are thin and muted; dot markers at each landmark have a white/page stroke. Y-axis grid lines are subtle (12% alpha). "VE ≈ 15×" note in bottom-right. Title reads "area-elevation-profile · julia · makie · anyplot.ai" in dark ink — fully readable. Axis labels "Elevation (m)" and "Distance (km)" clearly visible. Tick labels in dark secondary ink. All text readable against the light background. Landmark annotation text (fontsize 10) is small but legible at full resolution; may be marginal at 400 px mobile width.

Dark render (plot-dark.png): Near-black (#1A1A17) background. Title and axis labels flip to light (#F0EFE8 / #B8B7B0) — fully readable, no dark-on-dark failures. The filled terrain area becomes dark greenish (28% alpha green over near-black) — the silhouette effect is less pronounced than in the light render, but the solid profile line (#009E73) remains bright and clearly visible. Landmark annotation text uses the muted light token (#A8A79F) — readable. Data colors are identical to the light render (only chrome flips). Y-grid lines retain the same subtle character. All checks pass; both renders are theme-correct.

Both paragraphs are required. A review that only describes one render is invalid.

Score: 83/100

Category	Score	Max
Visual Quality	26	30
Design Excellence	12	20
Spec Compliance	15	15
Data Quality	15	15
Code Quality	9	10
Library Mastery	6	10
Total	83	100

Visual Quality (26/30)

• VQ-01: Text Legibility (5/8) — Title (fontsize 20), axis labels (14), and tick labels (12) are well-sized and readable in both themes. Landmark annotation text at fontsize 10 (20 source px) scales to ~2.5 px at 400 px mobile width — below mobile-readable threshold. VE note similarly small.
• VQ-02: No Overlap (6/6) — All landmark labels are well-positioned with no collisions. The Col de Neige label uses a negative offset to avoid the terrain peak, which works cleanly.
• VQ-03: Element Visibility (5/6) — Profile line and markers clearly visible in both themes. The filled terrain area at 28% alpha is prominent on light but noticeably dim on the dark background (dark green on near-black reduces silhouette contrast).
• VQ-04: Color Accessibility (2/2) — Single series, brand green #009E73, adequate contrast on both backgrounds. No red-green as sole signal.
• VQ-05: Layout & Canvas (4/4) — Canvas gate passed (3200×1800). Title fills ~65% of plot width. Good proportions, generous whitespace, no text overflow.
• VQ-06: Axis Labels & Title (2/2) — "Elevation (m)" and "Distance (km)" with units. Correct title format.
• VQ-07: Palette Compliance (2/2) — First series #009E73 throughout. Backgrounds #FAF8F1 light / #1A1A17 dark. All chrome tokens theme-adaptive.

Design Excellence (12/20)

• DE-01: Aesthetic Sophistication (5/8) — Above default: top/right spines removed, y-grid only at 12% alpha, white/page stroke on landmark markers for definition, muted semi-transparent connector lines. Clean professional polish, but no gradient coloring (optional spec feature not used) and all landmarks treated with equal visual weight.
• DE-02: Visual Refinement (4/6) — L-shaped spine frame, subtle y-grid, muted connector lines, white marker edge highlighting. Clearly above the 2-default.
• DE-03: Data Storytelling (3/6) — Trail narrative is coherent (Trailhead→Trail End), VE annotation provides important interpretation context. However, no visual hierarchy among landmarks — the Summit Peak (highest point) has no additional emphasis over lower waypoints.

Spec Compliance (15/15)

• SC-01: Plot Type (5/5) — Correct area/line chart with filled terrain silhouette.
• SC-02: Required Features (4/4) — Area fill ✓, start/end labeled ✓, landmark annotations with vertical connector lines ✓, VE factor noted ✓. Gradient coloring is optional (not implemented — acceptable).
• SC-03: Data Mapping (3/3) — X: distance in km (0–80), Y: elevation in meters (983–3221). Both axes labeled with units.
• SC-04: Title & Legend (3/3) — Title matches format exactly. No legend for single-series (appropriate).

Data Quality (15/15)

• DQ-01: Feature Coverage (6/6) — Terrain profile, filled silhouette, 6 annotated landmarks, dot markers, connector lines, VE note, 320 sample points.
• DQ-02: Realistic Context (5/5) — Fictional alpine traverse (80 km, 950–3221 m) with French alpine naming. Plausible and neutral.
• DQ-03: Appropriate Scale (4/4) — Values in realistic alpine range. VE ≈ 15× is plausible for route profiles. 320 sample points within spec's 50–500 range.

Code Quality (9/10)

• CQ-01: KISS Structure (2/3) — Helper functions lerp_elev and gauss_smooth each used once; justified for terrain generation but add complexity above pure KISS.
• CQ-02: Reproducibility (2/2) — Random.seed!(42) present.
• CQ-03: Clean Imports (2/2) — CairoMakie, Colors, Random — all used.
• CQ-04: Code Elegance (2/2) — Well-organized sections, no fake UI, named constants.
• CQ-05: Output & API (1/1) — Saves as plot-$(THEME).png, no bare plot.png.

Library Mastery (6/10)

• LM-01: Idiomatic Usage (4/5) — Correct use of band!, lines!, scatter!, text!. Proper axis property names (topspinevisible, rightspinevisible, etc.). RGBAf for semi-transparent colors. colorant"" from Colors.jl.
• LM-02: Distinctive Features (2/5) — band! is the key Makie-specific primitive for area fills between two curves. RGBAf alpha blending and text align tuple system are idiomatic Makie. Slightly above 1-default but no use of advanced features like recipes, observables, or theme system.

Score Caps Applied

• None

Strengths

• Perfect spec compliance: filled silhouette, all required landmarks, start/end labels, VE annotation
• Complete theme adaptation: all chrome tokens properly flip between light and dark with no dark-on-dark failures
• Clean use of band! (Makie-idiomatic area fill) combined with lines! for the profile overlay
• Realistic alpine terrain data with Gaussian smoothing for natural micro-texture
• White/page stroke on landmark markers provides clean definition against the terrain fill
• Six well-positioned landmark annotations with correctly offset labels

Weaknesses

• Landmark annotation text at fontsize=10 (effective 20 source px) is too small for mobile readability — at 400 px display width these drop to ~2.5 source px. Increase to fontsize=12 minimum (fontsize=13-14 preferred) for all annotation text and the VE note.
• Dark render terrain fill (28% alpha green over #1A1A17) is quite dim — the silhouette effect loses impact in dark mode. Increase the fill alpha to 0.40–0.45 for the dark theme, or use a theme-conditional alpha value.
• Summit Peak has no additional visual emphasis over other landmarks despite being the highest point and natural focal center — consider a larger/bolder marker or distinct color for the summit.

Issues Found

1. VQ-01 MINOR: Annotation text fontsize=10 too small for mobile readability
   • Fix: Increase all text! fontsize from 10 → 13 for landmark labels; the VE note can stay at 11 since it's tertiary
2. VQ-03 MINOR: Dark render fill too dim (0.28 alpha on #1A1A17)
   • Fix: Use THEME == "dark" ? 0.42 : 0.28 for the band alpha so the silhouette reads clearly on both surfaces
3. DE-03 LOW: All landmarks presented with equal weight; no focal point
   • Fix: Give the Summit Peak marker a larger size (12 vs 9) or use the INK color for its dot to differentiate the highest point

AI Feedback for Next Attempt

Increase landmark annotation fontsize from 10 to 13 for mobile readability. Make the band alpha theme-conditional (~0.28 light, ~0.42 dark) so the silhouette effect is equally prominent in both renders. For better data storytelling, give the Summit Peak landmark a larger or differently-styled marker to create a focal hierarchy among the six annotations.

Verdict: APPROVED

[github-actions]

🔧 Repair Attempt 1/4

Applied fixes based on AI review feedback.

Status: Repair completed, re-triggering review...

---

🤖 impl-repair

[claude]

AI Review - Attempt 2/3

Image Description

Light render (plot-light.png): The plot displays a filled alpine terrain elevation profile on a warm off-white (#FAF8F1) background. The terrain silhouette is rendered as a semi-transparent brand-green (#009E73, ~28% alpha) filled area beneath a solid #009E73 profile line, covering the x-range 0–80 km and y-range 500–3700 m. Six landmarks are annotated with thin muted connector lines, dot markers (larger for Summit Peak), and text labels showing name + elevation: Trailhead (983 m) bottom-left, First Pass (2753 m) upper-left, Summit Peak (3221 m) centered at the apex with a larger marker for emphasis, Col de Neige (2597 m) below the terrain line via negative offset, Grand Col (2888 m) upper-right, Trail End (1039 m) bottom-right. A subtle VE ≈ 15× note appears bottom-right. Title, axis labels ("Distance (km)", "Elevation (m)"), and tick labels are all clearly dark and readable against the light background. Horizontal-only grid lines are very subtle. Top and right spines removed. Legibility verdict: PASS.

Dark render (plot-dark.png): The same plot on a warm near-black (#1A1A17) background. The terrain silhouette fill uses higher alpha (~42%) giving a richer, more saturated deep-green appearance, while the profile line remains the same #009E73. All six landmark annotations carry over with identical dot positions, connector lines now in a muted light tone, and label text in #B8B7B0 (INK_SOFT for dark). Title and all axis text are light-colored (#F0EFE8 / #B8B7B0) and fully readable against the dark background — no dark-on-dark failures observed. Grid lines appear as subtle lighter-toned horizontal rules. The VE note remains visible in the lower-right. Data colors are identical between the two renders (same #009E73 green); only chrome flips. Legibility verdict: PASS.

Both paragraphs are required. A review that only describes one render is invalid.

Score: 90/100

Category	Score	Max
Visual Quality	29	30
Design Excellence	14	20
Spec Compliance	15	15
Data Quality	15	15
Code Quality	9	10
Library Mastery	8	10
Total	90	100

Visual Quality (29/30)

• VQ-01: Text Legibility (7/8) — All sizes explicitly set; proportions balanced. Trail End label at x=80 with right-alignment sits close to the right axis boundary but fully visible. Slight margin for improvement.
• VQ-02: No Overlap (6/6) — All landmark labels, connector lines, and VE note are clear; Col de Neige floats cleanly below the terrain line without collisions.
• VQ-03: Element Visibility (6/6) — Profile line (linewidth=2.5) and landmark markers (size 9–13) are well-adapted to the data density (320 pts).
• VQ-04: Color Accessibility (2/2) — Single-series Imprint green; CVD-safe; INK/INK_SOFT tokens provide full contrast.
• VQ-05: Layout & Canvas (4/4) — Canvas gate passed (3200×1800). Chart fills ~70% of canvas height with generous margins; well-balanced.
• VQ-06: Axis Labels & Title (2/2) — "Distance (km)" and "Elevation (m)" with correct units.
• VQ-07: Palette Compliance (2/2) — First series #009E73; background #FAF8F1 (light) / #1A1A17 (dark); chrome fully theme-adaptive in both renders.

Design Excellence (14/20)

• DE-01: Aesthetic Sophistication (6/8) — Strong design: clean terrain silhouette, theme-differentiated fill alpha (0.28 light / 0.42 dark), intentional Summit Peak emphasis via larger marker — clearly above library defaults.
• DE-02: Visual Refinement (4/6) — Top/right spines removed; y-only grid (xgridvisible=false); explicit spine colors; transparent connector lines (0.5 alpha) add polish. Not quite perfect — tick marks on axes retained, minor spacing opportunities remain.
• DE-03: Data Storytelling (4/6) — Visual hierarchy guides the viewer: Summit Peak as the focal apex with larger marker + taller label offset; Trailhead and Trail End as endpoints; Col de Neige annotated below the saddle. Terrain texture adds realism. Viewer follows the alpine traverse narrative clearly.

Spec Compliance (15/15)

• SC-01: Plot Type (5/5) — Correct filled elevation profile (band + line = terrain silhouette).
• SC-02: Required Features (4/4) — Filled silhouette ✓; start/end labels ✓; landmark annotations with connector lines ✓; VE noted (VE ≈ 15×) ✓.
• SC-03: Data Mapping (3/3) — Distance on x, Elevation on y; full 0–80 km range visible.
• SC-04: Title & Legend (3/3) — Title: area-elevation-profile · julia · makie · anyplot.ai matches required format. No legend (single series — correct).

Data Quality (15/15)

• DQ-01: Feature Coverage (6/6) — Multi-peak traverse with ascent, descent, col/saddles, and varied terrain texture. All elevation-profile aspects represented.
• DQ-02: Realistic Context (5/5) — Fictional alpine route with plausible French/English mountain names (Col de Neige, Grand Col, Summit Peak); neutral hiking/geography context.
• DQ-03: Appropriate Scale (4/4) — 80 km traverse, 983–3221 m elevation range — realistic for an alpine traverse in the Alps.

Code Quality (9/10)

• CQ-01: KISS Structure (2/3) — Two helper functions (lerp_elev, gauss_smooth) break the strict KISS Imports→Data→Plot→Save pattern. They are short and purposeful, but inline implementation would keep the script flat.
• CQ-02: Reproducibility (2/2) — Random.seed!(42) set.
• CQ-03: Clean Imports (2/2) — CairoMakie, Colors, Random — all three used.
• CQ-04: Code Elegance (2/2) — Clean, well-commented code explaining design decisions (alpha rationale, title length check). No fake UI.
• CQ-05: Output & API (1/1) — Saves as plot-$(THEME).png; uses current size= API.

Library Mastery (8/10)

• LM-01: Idiomatic Usage (5/5) — band!() for area fill, lines!(), scatter!(), text!() composited on a single Axis — textbook idiomatic CairoMakie.
• LM-02: Distinctive Features (3/5) — band!(ax, distance, fill(500.0, n), elevation) is the distinctively Makie approach to terrain silhouettes (not trivially replicable in matplotlib without fill_between + manual baseline). RGBAf() type-safe alpha color construction leverages Makie's color system.

Score Caps Applied

• None — no caps triggered.

Strengths

• Perfect spec compliance: all required features present (filled silhouette, landmark annotations, VE note, start/end labels)
• Both renders are fully theme-correct and readable; no dark-on-dark failures
• Summit Peak receives intentional visual hierarchy (larger marker, taller connector) — creates a clear focal point for the viewer
• Idiomatic use of band!() for terrain silhouette — the correct Makie primitive for this plot type
• Realistic, engaging alpine traverse scenario with authentic mountain naming

Weaknesses

• Helper functions lerp_elev and gauss_smooth break the flat KISS structure — consider inlining or simplifying data generation
• Trail End label at x=80 with right-alignment is tight against the right axis boundary; adding 1–2 km axis padding on the right (e.g., limits x to 83) would give it breathing room

Issues Found

1. CQ-01 MINOR: Two utility functions defined (lerp_elev, gauss_smooth) break strict flat-script KISS structure
   • Fix: Inline the linear interpolation or use a simpler parameterized noise generation without defining named functions
2. VQ-01 MINOR: Trail End label placement close to right axis boundary
   • Fix: Extend x-axis limit from 82.0 to 84.0 to give the right-aligned trail-end label more room

AI Feedback for Next Attempt

Strong implementation — spec fully satisfied, theme-adaptive chrome correct in both renders, good visual hierarchy. To push further: flatten helper functions into inline data generation to satisfy KISS, and add a small x-axis right margin (82→84) to give the Trail End label breathing room.

Verdict: APPROVED