MDEV-40985 row_end access out of bounds in ALTER TABLE - #5622
Merged
Conversation
|
|
Thirunarayanan
approved these changes
Sep 1, 2026
ha_innobase_inplace_ctx::create_key_defs(): In the assignment that had been introduced in commit e056efd (MDEV-25004), account for virtual columns. Until MDEV-22363 hopefully lands some day, InnoDB maintains two arrays of columns, which complicates the mapping between TABLE_SHARE::fields and dict_table_t::cols. This complication was not accounted for here. Reviewed by: Thirunarayanan Balathandayuthapani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ha_innobase_inplace_ctx::create_key_defs(): In the assignment that had been introduced in e056efd (MDEV-25004), account for virtual columns. Until MDEV-22363 hopefully lands some day, InnoDB maintains two arrays of columns, which complicates the mapping betweenTABLE_SHARE::fields and dict_table_t::cols. This complication was not accounted for here.