MDEV-40996 Support --sync_with_master 0, $variable in mysqltest - #5619
Open
ParadoxV5 wants to merge 1 commit into
Open
MDEV-40996 Support --sync_with_master 0, $variable in mysqltest#5619ParadoxV5 wants to merge 1 commit into
--sync_with_master 0, $variable in mysqltest#5619ParadoxV5 wants to merge 1 commit into
Conversation
Member
|
@ParadoxV5 mtr/mariadb-test changes can (and should) go into the earliest version, 10.11. They don't affect the server or production use, and it's rather annoying to remember what mtr feature was added in what version and adjust tests when merging up. Better keep mtr/mariadb-test the same everywhere whenever possible |
ParadoxV5
force-pushed
the
px5.sync_with_master-var
branch
from
September 2, 2026 04:42
153ee96 to
8b8d062
Compare
ParadoxV5
changed the title
--sync_with_master 0, $variable--sync_with_master 0, $variable in mysqltest
ParadoxV5
added
the
Rework
`--sync_with_master` uses `get_string()`, which has `$variable` support, but it only uses the read buffer, which is written with the unexpanded string and not the variable value. Reviewed-by: KhaledR57 <khaled57.dev@gmail.com>
KhaledR57
force-pushed
the
px5.sync_with_master-var
branch
from
September 2, 2026 20:44
8b8d062 to
d557ea8
Compare
Contributor
|
verified under ASAN, the test fails without the patch and passes with it. I amended two cosmetic things: declared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--sync_with_masterusesget_string(), which has$variablesupport, but it only uses the read buffer, which is written with the unexpanded string and not the variable value.