MDEV-24646/MDEV-39711: Fix System-Versioned UPDATE with VIRTUAL columns#5149
Draft
ParadoxV5 wants to merge 1 commit into
Draft
MDEV-24646/MDEV-39711: Fix System-Versioned UPDATE with VIRTUAL columns#5149ParadoxV5 wants to merge 1 commit into
ParadoxV5 wants to merge 1 commit into
Conversation
UPDATEs on System-Versioned Tables used stale data for Row Format Binary Logging’s after-image, which may be the before- value (MDEV-39711) or even invalidated memory (MDEV-24646).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses issues with system-versioned tables and virtual columns (specifically MDEV-24646 and MDEV-39711) by updating the virtual fields using VCOL_UPDATE_FOR_WRITE instead of VCOL_UPDATE_FOR_READ in TABLE::vers_update_fields(). It also adds corresponding replication test cases to verify the fix. There are no review comments, and I have no additional feedback to provide.
|
|
Contributor
Author
|
? do our CLA signatures expire |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATEs on System-Versioned Tables used stale data for Row Format Binary Logging’s after-image, which may be the before-value (MDEV-39711) or even invalidated memory (MDEV-24646).
This is outside of my domain/expertise, so can someöne (human or bot) explain why this 1-liner patch works and is the new mode appropriate?