10.6 mdev 39676#5100
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces character validation for Galera SST-related variables, specifically wsrep_sst_receive_address, wsrep_sst_donor, and wsrep_sst_method, by implementing check_request_str in sql/wsrep_sst.cc. It also updates Galera version strings and protocol versions across several test files and adjusts test scripts to handle platform-specific exit codes for server startup and pkill operations. Feedback indicates that the new validation logic is overly restrictive; both wsrep_sst_receive_address and wsrep_sst_donor should permit empty strings, and wsrep_sst_donor must support comma-separated lists. Furthermore, the test cleanup logic should be updated to allow pkill to return exit code 1 when no matching processes are found.
janlindstrom
force-pushed
the
10.6-MDEV-39676
branch
from
473b090 to
3c13b25
Compare
Add verification of wsrep_sst_donor, wsrep_sst_method and wsrep_sst_receive_address so that they contain only supported characters. But allow NULL or empty value.
Joiner mariadbd exits when SST is aborted; the exit code varies by platform (clean 0 on some systems, signalled 134 / 1 on others). pkill exit code can also vary by platform (clean 0 on some systems, signalled 1 others).
janlindstrom
force-pushed
the
10.6-MDEV-39676
branch
from
3c13b25 to
2495f6f
Compare
2 participants
No description provided.