Skip to content

Expose mission state and retain MAVLink ACK evidence - #2171

Draft
mbuckton wants to merge 6 commits into
developmentfrom
agent/reload-persisted-tasks
Draft

Expose mission state and retain MAVLink ACK evidence#2171
mbuckton wants to merge 6 commits into
developmentfrom
agent/reload-persisted-tasks

Conversation

@mbuckton

@mbuckton mbuckton commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What changed

  • decode and retain timestamped MISSION_CURRENT sequence, total, state, mission ID, and observation time on DroneTwin
  • map MAVLink mission states to explicit active, paused, complete, and related twin values
  • preserve the MAVLink 1 fallback when extension fields are absent
  • retain the last sent MAVLink message and last related drone response in the terminal MavlinkSendResult
  • preserve ACK evidence across an ADVANCE transition so a sequence that subsequently completes does not discard the accepted ACK

Why

The STANAG adapter must reconcile a recovered task from drone evidence and later prove whether the drone acknowledged a command. Previously an accepted ACK advanced the sender, but terminal completion replaced both sentMessage and receivedMessage with null, leaving only an inferred success.

This branch is coordinated with Maps-Messaging/stanag-state-adapter#30.

Validation

  • MavlinkEventListSenderTest: 37 of 37 pass, including retained ACK evidence after retry
  • mission-current listener tests cover MAVLink 2 fields and MAVLink 1 fallback
  • git diff --check passes

The normal Maven build remains blocked before compilation because io.mapsmessaging:dynamic_storage:2.5.3-SNAPSHOT is unavailable from the configured repositories.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e0efc744-6e35-41ec-b472-2d092b913011

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mbuckton mbuckton changed the title Expose timestamped MAVLink mission execution state Expose mission state and retain MAVLink ACK evidence Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant