Skip to content

fix(web): GitHub Go live lists only unsynced repos and shows its switches - #2689

Open
Makisuo wants to merge 3 commits into
mainfrom
t3/fix-github-source-ui
Open

Makisuo wants to merge 3 commits into
mainfrom
t3/fix-github-source-ui

refactor(web): GitHub repo status cell uses hstack

e3d1656
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 16, 2026 in 1m 0s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge. The only change since the last review is a class-preserving hstack refactor; the new filter and switch card are pinned by a scene test, though no test covers a partly-synced org still showing the ta…
no findings · tests partial −1 · risk low

The GitHub Go live step now lists only unsynced repositories, shows the CI traces and PR review switches with a pointer to the source's Connection tab, and drops Cancel once the source is saved. Safe to merge.

What was checked
  • hstack with inline: true/justify: "end" emits inline-flex and justify-end beside w-28 shrink-0 text-xs (stack.ts:59-70, stack.ts:108-113)
  • The embedded flow routes ToggledCiTraces through GotIntegrationsMessage, so the new switch writes from Go live (view-integration.ts:75)
  • Integration sources do show a Connection tab, so the new copy resolves (kit/shared.ts:86-89); repoTable's removed empty state is unreachable from its only call site

e3d1656 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.