Repository navigation
fix(landing): underline only the region claim text, not the US/EU chips - #2688
Merged
Merged
Conversation
Maple review🟢 Confidence 10/10 · safe to merge. Markup-only decoration fix in one Astro component; underline moves to a text span, hover coloring preserved via Moves the pricing hero's
|
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pricing hero's "Hosted in the US or the EU" link set its underline on the whole ``, so it ran under the US and EU chips too. `no-underline` on the chip wrapper can't cancel a decoration inherited from the parent.
The underline now sits on a span around the text only; the link is a `group` so hover still turns it orange. Icon and chips stay undecorated.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.