Skip to content

fix(landing): underline only the region claim text, not the US/EU chips - #2688

Merged
Makisuo merged 1 commit into
mainfrom
t3/fix-weird-underline
Nov 16, 2026
Merged

Makisuo merged 1 commit into
mainfrom
t3/fix-weird-underline

Conversation

@Makisuo

@Makisuo Makisuo commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

The pricing hero's "Hosted in the US or the EU" link set its underline on the whole ``, so it ran under the US and EU chips too. `no-underline` on the chip wrapper can't cancel a decoration inherited from the parent.

The underline now sits on a span around the text only; the link is a `group` so hover still turns it orange. Icon and chips stay undecorated.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Devin Review

@maple-review-bot

maple-review-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Markup-only decoration fix in one Astro component; underline moves to a text span, hover coloring preserved via group.
no findings · tests not needed · risk low

Moves the pricing hero's /eu link underline from the <a> onto a span around the region-claim text, so it no longer runs under the US/EU chips. Contained markup change with no behavior outside that link.

  • PricingHero underlines only the region-claim text, not the chips

07bd9a1 · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@Makisuo
Makisuo merged commit ee02220 into main Nov 16, 2026
23 of 24 checks passed
@Makisuo
Makisuo deleted the t3/fix-weird-underline branch November 16, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant