Skip to content

fix(warehouse): service_usage forward query back to SELECT * after the 0068 deploy - #2683

Merged
Makisuo merged 1 commit into
mainfrom
service-usage-forward-query-reset
Nov 16, 2026
Merged

Makisuo merged 1 commit into
mainfrom
service-usage-forward-query-reset

Conversation

@Makisuo

@Makisuo Makisuo commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #2681. Its Tinybird deployment needed service_usage's forward query to list every column with the two new profiles columns defaulted, so Tinybird would refill the table from the live copy (365 days) rather than from source tables that keep 14 to 90 days. That one-shot query must not stay: the next rebuild of service_usage would set ProfileRowCount and ProfileSizeBytes back to 0.

This returns it to SELECT *, which still refills from the live table, and regenerates the manifest and schema files (only the project revision hash changes there).

Order: merge only after #2681's Tinybird deployment is live in us and eu, then run bun run tinybird:deploy check, start and promote for this one.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Devin Review

…e 0068 deploy

The explicit column list was a one-shot for the deploy that added the profiles
columns. Left in, the next rebuild of service_usage would reset ProfileRowCount
and ProfileSizeBytes to 0.
@maple-review-bot

maple-review-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Restores exactly the SELECT * state service_usage held before #2681; only the Tinybird deploy order decides safety.
no findings · tests not needed · risk low

Puts service_usage back on forwardQuery: SELECT * and regenerates the four revision-pinned files, undoing the one-shot column list so a future rebuild still refills from the 365-day live table. Safe to merge once #2681's Tinybird deploy is live.

  • serviceUsage forward query returns to SELECT * instead of the one-shot defaulted column list
  • Tinybird project revision moves to 3fd7108… in the manifest, ClickHouse schema, insert mappings and local schema files

Before merge

c760eda · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Clippy (1.99.1)

Clippy execution failed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@Makisuo
Makisuo merged commit 64d6962 into main Nov 16, 2026
46 of 47 checks passed
@Makisuo
Makisuo deleted the service-usage-forward-query-reset branch November 16, 2026 01:15
@maple-review-bot

Copy link
Copy Markdown

Merged with 2 steps from "Before merge" still open. If they are done, tick them on the review comment; if not, now is the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant