fix(ingest): count TypeScript ADK's call_llm as the model call - #1170
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Sep 30, 2026 in 1m 5s
Confidence 4/5 · No issues found
🟢 Confidence 4/5 · likely safe to merge
Contained to one vendor's stamping, and the Python and TypeScript paths each have a test that FAILs against the old guard.
quality 100/100 · no findings · tests covered · risk medium
Drops the google_adk + call_llm early-out in is_model_call so the operation decides, letting TypeScript ADK's call_llm (stamped chat) be the model call while Python's wrapper still is not. Safe to merge; both dialects are covered by tests.
is_model_callno longer short-circuits ongoogle_adkspans namedcall_llm- ADK
call_llmwithgen_ai.operation.name=chatnow stamps buckets andmaple_ai.llm_call=1 - New
google_adk_ts_call_llm_owns_usagetest pins the TypeScript path
What was checked
- Python
call_llmhas no op and noopeninference.span.kind, so it still missesINFERENCE_OPSandgoogle_adkdoes not start withunknown:(usage.rs:194,facts.rs:251) - The removed arm sat before only the generic op check, so
litellm,semantic_kernelandvercel_ai_sdkordering is unchanged - TS buckets
[600,400,0,100,0]follow frominput_excludes_cachefalse forgemini-2.5-flash(usage.rs:223), matching the new assertion
9a516c1 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading