Repository navigation
feat(browser): error filters and linked error causes - #1146
Merged
Makisuo merged 4 commits intoSep 29, 2026
Merged
Maple Review Bot / Maple / review
succeeded
Sep 29, 2026 in 7m 49s
Confidence 4/5 · No issues found
Confidence 4/5 · likely safe to merge
F2's fix is real and the new filter path is unit- and browser-tested; only the frame-URL regex's less common formats are untested.
quality 100/100 · no findings · tests covered · risk medium
Adds errors capture filters (ignore/denyUrls/allowUrls/beforeCapture plus default extension and ResizeObserver drops) evaluated before the exception span is created, and appends cause/AggregateError chains to exception.stacktrace. The global-regex fix at this head is correct; safe to merge.
shouldCapturedrops ignored, extension andResizeObservererrors beforerecordExceptionstarts a spanconfigureErrorFilterswiresconfig.errorsthroughinitand the runtime shutdownexceptionOfappendsCaused by:blocks fromcauseandAggregateErrorchains toexception.stacktracewindow.onerrorpassesevent.filenameas the top frame when noErrorwas thrown
Fixed since the last review
F2 · A/gregex inignore/denyUrls/allowUrlsmatches only every other error
What was checked
matchesresetspattern.lastIndexbeforetest(error-filters.ts:50), so/gignore lists drop every match — F2's defect is goneFRAME_URLreads V8 and SpiderMonkey frames and not a URL in the message line (error-filters.test.ts:23, :34)frameUrlfromwindow.onerrortakes precedence over a wrappedError's SDK stack (error-filters.ts:68, errors.ts:150)
c095d88 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple to ask about one.
Loading