Skip to content

fix(ingest): detect the remaining agent instrumentation scopes - #1138

Merged
JeremyFunk merged 2 commits into
mainfrom
fix/ingest-detect-remaining-agent-scopes
Sep 30, 2026
Merged

JeremyFunk merged 2 commits into
mainfrom
fix/ingest-detect-remaining-agent-scopes

fix(ingest): read haystack's session.id only on its OpenInference spans

6f3f68e
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Sep 30, 2026 in 9m 4s

Confidence 4/5 · No issues found

🟢 Confidence 4/5 · likely safe to merge
Every new scope, session-key order and integration registration is exercised by ingest and vendor tests; I found no defect in the classification paths I traced.
quality 100/100 · no findings · tests covered · risk medium

Extends ingest vendor detection to more AI instrumentation scopes (TS LangChain, OpenInference haystack/google_adk/pydantic_ai, .NET Semantic Kernel, Genkit), fixes their session-key order, and resolves those vendor ids to the OpenInference dialect. Contained to ingest classification plus integration lookup; safe to merge.

  • Ingest recognises the TS LangChain, OpenInference haystack/google_adk/pydantic_ai, .NET Semantic Kernel and genkit-tracer scopes
  • Dual-writing OpenInference spans stamp unknown:openinference instead of unknown:genai
  • haystack splits into two vendor entries with dialect-specific session keys
  • google_adk, haystack, pydantic_ai resolve to the OpenInference integration
What was checked
  • Every new exact scope arm also has a SCOPE_NAMES entry, so SCOPE_SCREEN admits it (ai_session.rs:298,308,318)
  • New OpenInference registrations stay a superset: mergeSources keeps the default GenAI keys first, so native google_adk/haystack/pydantic_ai spans lose no field (ai-vendors.ts:219)
  • detect_unknown_openinference still matches every span detect_unknown_genai now refuses, since both key on openinference.span.kind (ai_session.rs:1307)

6f3f68e · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.