fix(ingest): detect the remaining agent instrumentation scopes - #1138
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Sep 30, 2026 in 9m 4s
Confidence 4/5 · No issues found
🟢 Confidence 4/5 · likely safe to merge
Every new scope, session-key order and integration registration is exercised by ingest and vendor tests; I found no defect in the classification paths I traced.
quality 100/100 · no findings · tests covered · risk medium
Extends ingest vendor detection to more AI instrumentation scopes (TS LangChain, OpenInference haystack/google_adk/pydantic_ai, .NET Semantic Kernel, Genkit), fixes their session-key order, and resolves those vendor ids to the OpenInference dialect. Contained to ingest classification plus integration lookup; safe to merge.
- Ingest recognises the TS LangChain, OpenInference haystack/google_adk/pydantic_ai, .NET Semantic Kernel and
genkit-tracerscopes - Dual-writing OpenInference spans stamp
unknown:openinferenceinstead ofunknown:genai - haystack splits into two vendor entries with dialect-specific session keys
google_adk,haystack,pydantic_airesolve to the OpenInference integration
What was checked
- Every new exact scope arm also has a
SCOPE_NAMESentry, soSCOPE_SCREENadmits it (ai_session.rs:298,308,318) - New OpenInference registrations stay a superset:
mergeSourceskeeps the default GenAI keys first, so native google_adk/haystack/pydantic_ai spans lose no field (ai-vendors.ts:219) detect_unknown_openinferencestill matches every spandetect_unknown_genainow refuses, since both key onopeninference.span.kind(ai_session.rs:1307)
6f3f68e · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading