Skip to content

feat(native): a long press opens a row's menu as the system's - #489

Merged
Makisuo merged 12 commits into
t3/ios-haptics-long-pressfrom
t3/ios-long-press-menus
Nov 15, 2026
Merged

Makisuo merged 12 commits into
t3/ios-haptics-long-pressfrom
t3/ios-long-press-menus

test(web): pin sidebar channel and DM rows' long-press menus, the sam…

210f1dd
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 15, 2026 in 1m 14s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Only the sidebar scene test changed since the last pass; it asserts the props the code actually emits at this head.
no findings · tests covered · risk low

A long press on a sidebar or message row now opens the row's own menu as the iOS system menu, built from the same entries its "⋯" trigger uses. The one file new since the last pass is the sidebar scene test, and it holds.

  • longPressMenu renders a row's menu entries as a context-menu island, nothing when an entry lacks words
  • rowLongPress/dmLongPress share rowMenu/dmMenu with each row's dots trigger
  • The iOS host builds the menu with the menu island's own builder

Before merge

  • Manual · Merge #488 (t3/ios-haptics-long-press) first: this branch is stacked on it
What was checked
  • Expected props strings match nativeMenuItems' key order and separator collapsing (ui/menu.ts:252)
  • canDeleteChannels is false here (membership: null), so the expected channel menu correctly omits Delete
  • Both rows render: sidebarItem spreads the long-press attributes (items.ts:129, items.ts:352)

210f1dd · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.