Skip to content

feat(native): haptics that components own - #488

Merged
Makisuo merged 7 commits into
mainfrom
t3/ios-haptics-long-press
Nov 15, 2026
Merged

Makisuo merged 7 commits into
mainfrom
t3/ios-haptics-long-press

test(web): the replaced toast restarts exactly one dismissal timer

b20dc50
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 15, 2026 in 29s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Only the toaster test changed since the last pass and it now catches the defect F2 described; native haptic feel is still unverified on a device.
no findings · tests covered · risk medium

Component-owned iOS haptics: presses are marked with data-native-feedback and played in the host's on_press, outcome toasts return a PlayToastFeedback command, and iOS maps each kind to a UIKit generator. Nothing new is wrong in the file that changed since the last pass.

Fixed since the last review

  • ✅ F2 · toContain stops pinning the toaster's timer command set
What was checked
  • The replacement-timer assertion now filters WaitBeforeDismissal and requires length 1, so a doubled timer fails (toaster.test.ts:138)
  • The one-name toEqual the rule dislikes is genuinely illegal: no-exact-name-list only fires on two or more distinct names (scripts/oxlint-plugins/test-slop.mjs:468)
  • commandNames reads names without executing commands, so the haptics test plays no haptic into systemUi() (toaster.test.ts:107)

b20dc50 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.