Repository navigation
feat(native): haptics that components own - #488
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Nov 15, 2026 in 29s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Only the toaster test changed since the last pass and it now catches the defect F2 described; native haptic feel is still unverified on a device.
no findings · tests covered · risk medium
Component-owned iOS haptics: presses are marked with data-native-feedback and played in the host's on_press, outcome toasts return a PlayToastFeedback command, and iOS maps each kind to a UIKit generator. Nothing new is wrong in the file that changed since the last pass.
Fixed since the last review
- ✅
F2 ·toContainstops pinning the toaster's timer command set
What was checked
- The replacement-timer assertion now filters
WaitBeforeDismissaland requires length 1, so a doubled timer fails (toaster.test.ts:138) - The one-name
toEqualthe rule dislikes is genuinely illegal:no-exact-name-listonly fires on two or more distinct names (scripts/oxlint-plugins/test-slop.mjs:468) commandNamesreads names without executing commands, so the haptics test plays no haptic intosystemUi()(toaster.test.ts:107)
b20dc50 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading