Experimental colors#4233
Open
barollet wants to merge 9 commits intoManimCommunity:experimentalfrom
Open
Conversation
…color for fill and stroke
…guments in setter
…into experimental_colors
for more information, see https://pre-commit.ci
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
It removes color attributs from Mobject and OpenGLMobject and fully delegates it to the vectorized child.
Some code is factored into a new ManimColorArray class in the color core file. This class handles creating and updating arrays of colors and opacity regardless of wether a single argument, list or no argument are given for opacity and color. Color and opacity attributes are now instances of this class instead of two separate attributes.
The get_colors and get_opacities variants are modified to access this new attribute so the change is not breaking if we keep using the getters and not direct attribute access.
Motivation and Explanation: Why and how do your changes improve the library?
Mobject is a baseclass where instances are not supposed to be displayed so color attributes do not belong here.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist