fix(updatenotification): use process.argv[0] as restart binary#4163
Open
KristjanESPERANTO wants to merge 1 commit into
Open
fix(updatenotification): use process.argv[0] as restart binary#4163KristjanESPERANTO wants to merge 1 commit into
KristjanESPERANTO wants to merge 1 commit into
Conversation
PR MagicMirrorOrg#4156 hardcoded `node` as the interpreter, causing a crash when restarting under Electron - `require("electron")` returns only a path string in plain Node, making `electron.app` undefined. Closes MagicMirrorOrg#4154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The restart approach I introduced in #4156 still crashes under Electron:
nodeRestart()hardcodesnodeas the interpreter, but under Electronprocess.argv[0]is the Electron binary. Spawningnode js/electron.jscausesrequire("electron")to return a string instead of the API, soelectron.appisundefined.This uses
process.argv[0]as the binary directly, which works for both Electron and plain Node.I introduced more variables for more clarity.
Fixes #4154.