Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion defaultmodules/weather/providers/weathergov.js
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ class WeatherGovProvider {
days.push(weather);
}

return days.slice(1); // Skip first incomplete day
return days;
}

#generateWeatherObjectsFromHourly (forecasts) {
Expand Down
30 changes: 30 additions & 0 deletions tests/unit/modules/default/weather/providers/weathergov_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,36 @@ describe("WeatherGovProvider", () => {
expect(day).toHaveProperty("weatherType");
expect(day).toHaveProperty("precipitationProbability");
});

it("should not skip the first day of forecast data", async () => {
const provider = new WeatherGovProvider({
lat: 40.71,
lon: -74.0,
type: "forecast"
});

const dataPromise = new Promise((resolve) => {
provider.setCallbacks(resolve, vi.fn());
});

server.use(
http.get(WEATHERGOV_FORECAST_URL, () => {
return HttpResponse.json(forecastData);
})
);

await provider.initialize();
provider.start();

const result = await dataPromise;

// Mock data starts on 2026-02-06 ("This Afternoon").
// Before the fix, slice(1) dropped today, so result[0] would have been 2026-02-07.
const firstDate = result[0].date;
expect(firstDate.getFullYear()).toBe(2026);
expect(firstDate.getMonth()).toBe(1); // February (0-indexed)
expect(firstDate.getDate()).toBe(6);
});
});

describe("Hourly Parsing", () => {
Expand Down