Fix: Prevent duplicate media query blocks when resolving multiple variables#144
Open
aroskar wants to merge 1 commit intoMadLittleMods:masterfrom
Open
Fix: Prevent duplicate media query blocks when resolving multiple variables#144aroskar wants to merge 1 commit intoMadLittleMods:masterfrom
aroskar wants to merge 1 commit intoMadLittleMods:masterfrom
Conversation
…iables When multiple CSS variables are used in a single property within a media query, the plugin was generating duplicate query blocks, causing significant CSS bloat. Root Cause: 1. eachMapItemDependencyOfDecl was passing entire variable list to gatherVariableDependencies on every iteration instead of single variable, causing duplication 2. Missing check to skip duplicate at-rules when variable already in scope Example (from issue MadLittleMods#67): Input: ```css :root { --space-small: 10px; --space-large: 20px; } h1 { padding: var(--space-small) var(--space-large); } @media (min-width: 768px) { :root { --space-small: 20px; --space-large: 30px; } } ``` Before Fix (Buggy Output): ```css h1 { padding: 10px 20px; } @media (min-width: 768px) { h1 { padding: 20px 30px; } } @media (min-width: 768px) { h1 { padding: 20px 30px; } } @media (min-width: 768px) { h1 { padding: 20px 30px; } } @media (min-width: 768px) { h1 { padding: 20px 30px; } } ``` After Fix (Correct Output): ```css h1 { padding: 10px 20px; } @media (min-width: 768px) { h1 { padding: 20px 30px; } } ``` Solution: 1. Pass only current variable to gatherVariableDependencies 2. Skip creating duplicate at-rules when declaration and variable are in same at-rule context Impact: - Fixes issue MadLittleMods#67 - Eliminates unecessary/duplicate @media blocks Testing: - Added 2 new test cases covering multiple variables in single property - All exiting tests are passing Closes MadLittleMods#67
Author
|
@MadLittleMods could you please help review this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of the Issue
When multiple CSS variables are used in a single property within a media query, the plugin was generating duplicate query blocks, causing significant CSS bloat.
Root Cause:
Example (from issue #67):
Input:
Before Fix (Buggy Output):
After Fix (Correct Output):
Solution:
Impact:
Testing:
Closes #67