Repository navigation
feat: move the game to saga a2ui 1.0.1 - #9
Conversation
Install @saga-a2ui/react-mcp-stack 1.0.1 from npm latest and point the credit's tutorial link at the 1.0.0 documentation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
left a comment
There was a problem hiding this comment.
Helmet-Review-Request: #9 (comment)
Reviewed the full merge-base (9f3c0f8) to head (f010795) diff, 7 files, at the live head.
Verified OK:
- The dependency bump is consistent across package.json, apps/tic-tac-toe/game/package.json and the lockfile. The lockfile resolves react-mcp-stack 1.0.1 with core 1.0.0, components 1.0.0, react 1.0.0 and mcp 1.0.2. Every integrity hash matches
npm viewon the registry. Thelatesttag is 1.0.1. npm cisucceeds.npm run typecheckpasses, the game tests pass (45) and the worker tests pass (16).npm run build(the Wrangler dry run) passes.- Not verified here: the icon-digest check and 4 of the 9 Playwright tests fail in this sandbox only because git-lfs is not installed, so the PNGs are LFS pointer files. They fail on the dragon-icon digest assertion, which this diff does not touch. I confirmed by reading that the credit-link assertion in card.spec.ts matches catalog.tsx.
Blocking defect:
- apps/tic-tac-toe/game/src/catalog.tsx:162 (also apps/tic-tac-toe/browser/card.spec.ts:240, README.md:13 and docs/tic-tac-toe-data-handling.md:21) point the credit's "how to build your Saga" link at https://docs.saga-a2ui.dev/docs/releases/1.0.0/guides/build-tic-tac-toe-with-react. That URL returns HTTP 404 today (checked repeatedly, also without the trailing slash and for /releases/1.0.0/). The SDK repo has no docs/releases/1.0.0 snapshot on main (only 0.11.0-rc.1 and 0.7.6), and no open SDK PR adds one. The docs site publishes only committed release snapshots (docs/mintlify.md), so nothing will publish this page by itself. The old 0.11.0-rc.1 link returns 200. Merging as written ships a dead link behind the game's primary call to action, and the browser test cannot catch it because it only compares the string.
Requested change: keep the link on a working URL until the SDK's 1.0.0 docs snapshot is published, then land the link change once it returns 200. The alternative is to hold this PR until that snapshot is live. The dependency bump itself is fine and can go in either way.
…re live Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
left a comment
There was a problem hiding this comment.
Helmet-Review-Request: #9 (comment)
Reviewed the full merge-base (9f3c0f8) to head diff at 308391b: README.md, package.json, apps/tic-tac-toe/game/package.json and package-lock.json. No material defects.
Verified:
- npm
latestandnextare both@saga-a2ui/react-mcp-stack1.0.1. Its published dependencies (core 1.0.0, components 1.0.0, react 1.0.0, mcp 1.0.2) match the lockfile entries, and the lockfile integrity hashes match the registry for all five packages. Root and game manifests are updated together as the README requires. - The follow-up commit fixes the 404 found on the earlier head: the credit link stays on the 0.11.0-rc.1 tutorial in catalog.tsx, card.spec.ts and the data-handling notes. It returns 200, while the 1.0.0 URL still returns 404.
- On a clean
npm ciof this head: typecheck, game tests (45), worker tests (16) and the Wrangler dry-run build pass. In Playwright, the 5 non-icon tests pass. The 10 dragon-digest tests andcheck-iconsfail only because git-lfs is not installed in this runtime: the PNG is a pointer file whose oid equals the expected digest, and the blob is identical to base. The PR does not touch any PNG, so this is not a defect of the change.
Non-blocking: the PR description still says the credit link goes to the 1.0.0 tutorial, but the final diff keeps the 0.11.0-rc.1 link on purpose. Updating the description would avoid confusion.
Moves the game from the release candidate to the stable saga a2ui release on npm
latest.@saga-a2ui/react-mcp-stack1.0.0-rc.1→1.0.1. The lockfile resolves the siblings it pins:core,componentsandreactat1.0.0, andmcpat1.0.2.docs/releases/1.0.0/guides/build-tic-tac-toe-with-react. The README and data-handling notes say the same.npm run checkpasses: brand and icon checks, typecheck, game tests (45), worker tests (16), Playwright (15) and the Wrangler dry-run build.🤖 Generated with Claude Code