Repository navigation
ci: retain repository traffic measurements - #6
Merged
Merged
Conversation
yia-mw-agent
approved these changes
Oct 31, 2026
yia-mw-agent
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the full merge-base (6431e6a) to head diff against main: .github/workflows/traffic.yml and docs/repository-traffic.md, at c424548. No material defects.
Checked:
- Action pins match FAVA Trails' traffic workflow (checkout, traffic-to-badge v1.4.0, actions-gh-pages v4.0.0). I read the pinned collector's source. It clones the existing
trafficbranch into.traffic, replaces views/clones by timestamp, drops the current and oldest boundary days, and writestraffic_{views,clones,paths,referrers}.jsonundertraffic-<repo>/. It fails on any API error, so the file names the retention step copies exist and a failed run publishes nothing. This matches the documented behavior. - The credential guard fails explicitly when
TRAFFIC_TOKENis empty. The publish step uses onlyGITHUB_TOKEN, and thecontents: writescope is limited to the job. The concurrency group serializes the writer. - I ran the retention step against stub data, twice. The copy and same-date overwrite behave as documented. I could not run the
jqreceipt locally because jq is not installed here. The expression is simple and ubuntu-latest provides jq. - Whitespace check is clean and the existing CI check passes. The change touches no application code, so I did not rerun the app suite. actionlint is not installed here; the author reports it passes.
- The docs match the code and are accurate about the limits. They state that referrers and paths are not additive and that uniques do not sum across days. They do not claim operational collection, which the PR says must be verified after merge.
Non-blocking:
observed_atis read after collection, so a run crossing 00:00 UTC could file a receipt under the next date. The window is seconds and a missing or odd date is documented as missing evidence.- No
TRAFFIC_TOKENsecret is visible to me at the repository level (the org-level list is not enumerable). The first manual dispatch after merge decides whether collection works, as the PR already states.
Helmet-Review-Request: #6 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
GitHub's short traffic window currently has no scheduled archive in this repository. Add one daily/manual collector using the exact pinned actions already running in FAVA Trails, retaining daily views/clones by timestamp and dated referrer/path observations on the separate
trafficbranch. Same-day retries replace the observation; failed collection never publishes a zero sample. Document metric limits, credential scope, archive ownership and recovery. This public workflow collects only its own repository.Validation
npm run checkpasses: types, 45 game tests, 16 Workers tests, 13 browser tests and dry-run Worker build (Node 26.12.1).TRAFFIC_TOKENfails explicitly. No credential creation, permission expansion, SDK publication or service deployment.The delivery coordinator will verify the landed revision and actual collection separately.