Repository navigation
build: consume the SDK packages from the npm registry with a lockfile - #4
Merged
Merged
Conversation
Replace the four connector and card icon files with the operator-selected second edition, unchanged: head crops for the composer icons (the card's 24 px mark follows the composer icon) and the full mark on a tile for the logos. Update the recorded digests and the README.
Commit package-lock.json, resolving the seven-package 0.11.0-rc.1 SDK set that the application uses (core, components, mcp, react, react-mcp-stack) to the registry with integrity hashes. CI installs with npm ci. Remove the script that packed the pinned revision locally, now that the packages are published. Also record in the README that the second edition of the dragon artwork is deployed and was seen in both web hosts' cards, with the limits that remain.
timeleft--
approved these changes
Oct 30, 2026
timeleft--
left a comment
Member
There was a problem hiding this comment.
Reviewed the full patch and committed lockfile at this exact head. All package resolutions are public registry URLs with integrity; all five SDK identities/integrities match the independently published release. An isolated anonymous npm ci and the owning npm run check pass: four icon digests, types, 16 real Worker tests, 13 Chromium rendered-card tests, and Worker dry-run build; all four LFS pointers validate. Canonical game source and application runtime remain unchanged. README accurately preserves host-icon and first-load limitations. Current-head CI is green, branch rules and review threads were checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The SDK packages this application uses are now on the public npm registry, so this repository installs them the ordinary way.
package-lock.json, generated from the unchangedpackage.json. It resolves@saga-a2ui/core,components,mcp,reactandreact-mcp-stackto exactly0.11.0-rc.1fromregistry.npmjs.org, with integrity hashes.npm ciinstead of the step that packed the pinned SDK revision locally.scripts/qualify-sdk-packages.mjs, itsqualify:sdkscript and the.qualify/ignore entry. Nothing else used them, and keeping an optional second install path would only invite drift.Not changed: no package version, API or application code; no deployment; the pinned canonical game-source archive (
sdk-source.json) is untouched. Packages come from the registry through the lockfile; the game's own source stays the pinned SDK archive. They have separate owners.Validation
0.11.0-rc.1versions are public undernext;latestis unchanged and is not used here.registry.npmjs.orgwith an integrity value, and nofile:, link or workspace resolutions. The five SDK entries' integrity values equalnpm view @saga-a2ui/<name>@0.11.0-rc.1 dist.integrity.npm ciwith npm 10 (the version bundled with the pinned Node 22) installs from that lockfile, with no--legacy-peer-depsand no local tarballs.npm run checkrun once on the final registry-installed tree: icon digests (4 match), typecheck, 16 Workers-runtime tests, 13 rendered-card tests in Chromium, and the Worker build dry run all pass.scripts/check-lfs.pyvalidates the 4 LFS pointers.Limits
e89a6cb8-ee7b-4d6d-812d-3d9f84f6b8f6from9403b8f) and seen in the cards of both web hosts, each after one supported Retry. It does not claim reliable first load or reload, a changed Claude connector row (still a placeholder letter), or a changed icon on the existing ChatGPT plugin, which keeps the dragon uploaded earlier.latesttag is not promoted.